You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by jv...@apache.org on 2005/10/04 03:40:35 UTC

svn commit: r293484 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java

Author: jvanzyl
Date: Mon Oct  3 18:40:32 2005
New Revision: 293484

URL: http://svn.apache.org/viewcvs?rev=293484&view=rev
Log:
o using new feature in p-d-c which allows the setting of the logging
manager. this allows the embedder user to specify a logger manager that
can be controlled by client code.


Modified:
    maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java

Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java
URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java?rev=293484&r1=293483&r2=293484&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java (original)
+++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java Mon Oct  3 18:40:32 2005
@@ -314,7 +314,7 @@
     {
         MojoDescriptor mojoDescriptor = mojoExecution.getMojoDescriptor();
 
-        // NOTE: I'm putting these checks in here, since this is the central point of access for 
+        // NOTE: I'm putting these checks in here, since this is the central point of access for
         // anything that wants to execute a mojo.
         if ( mojoDescriptor.isProjectRequired() && !session.isUsingPOMsFromFilesystem() )
         {
@@ -1110,32 +1110,7 @@
     {
         container = (PlexusContainer) context.get( PlexusConstants.PLEXUS_KEY );
 
-        LoggerManager manager = null;
-
-        try
-        {
-            manager = (LoggerManager) container.lookup( LoggerManager.ROLE );
-
-            mojoLogger = new DefaultLog( manager.getLoggerForComponent( Mojo.ROLE ) );
-        }
-        catch ( ComponentLookupException e )
-        {
-            throw new ContextException( "Error locating a logger manager", e );
-        }
-        finally
-        {
-            if ( manager != null )
-            {
-                try
-                {
-                    container.release( manager );
-                }
-                catch ( ComponentLifecycleException e )
-                {
-                    getLogger().error( "Error releasing the logger manager - ignoring", e );
-                }
-            }
-        }
+        mojoLogger = new DefaultLog( container.getLoggerManager().getLoggerForComponent( Mojo.ROLE ) );
     }
 
     public void initialize()



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org