[jira] [Commented] (HADOOP-10659) Refactor AccessControlList to reuse utility functions and to improve performance

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017181#comment-14017181 ] 

Hadoop QA commented on HADOOP-10659:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12648216/HADOOP-10659.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl

                                      The following test timeouts occurred in hadoop-common-project/hadoop-common:

org.apache.hadoop.http.TestHttpServer

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4002//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4002//console

This message is automatically generated.

> Refactor AccessControlList to reuse utility functions and to improve performance
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-10659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10659
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>            Priority: Minor
>         Attachments: HADOOP-10659.patch
>
>
> Minor improvements can be done on _AccessControlList_.
> Code Reusability:
> _AccessControlList_ sanitizes the input list to remove duplicate entries, trim entries. _StringUtils.getTrimmedStringCollection_ can be used in this case.
> Performance:
> _AccessControlList_  uses TreeSet to maintain set of users and groups.
> HashSet improves the performance slightly.



--
This message was sent by Atlassian JIRA
(v6.2#6252)