You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/02/21 20:26:32 UTC

[GitHub] flink pull request #5554: [FLINK-8729][streaming] Refactor JSONGenerator to ...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5554

    [FLINK-8729][streaming] Refactor JSONGenerator to use jackson

    ## What is the purpose of the change
    
    This PR ports the `JSONGenerator` to rely on jackson instead of `org.apache.sling`.
    
    ## Brief changelog
    
    * refactor JSONGenerator
    * remove org.apache.slink dependency from flink-streaming-java
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as `JsonGeneratorTest`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8729

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5554
    
----
commit bbbc3aaced575f7e08141794e756fa25723d0f82
Author: zentol <ch...@...>
Date:   2018-02-21T14:30:16Z

    [FLINK-8729][streaming] Refactor JSONGenerator to use jackson

----


---

[GitHub] flink issue #5554: [FLINK-8729][streaming] Refactor JSONGenerator to use jac...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5554
  
    merging.


---

[GitHub] flink pull request #5554: [FLINK-8729][streaming] Refactor JSONGenerator to ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5554


---