You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/08/25 13:30:46 UTC

[GitHub] [trafficcontrol] mattjackson220 commented on pull request #4916: Multi interface health

mattjackson220 commented on pull request #4916:
URL: https://github.com/apache/trafficcontrol/pull/4916#issuecomment-680026440


   Looks really close to me. TO and TM unit tests pass, API tests pass, docs build and look good, manual testing works as expected.
   only thing ive noticed is that all interfaces in `/cache-statuses` have the same bandwidth, making the total bandwidth off too. i think its a bug in cachestate.go lines 181-187.  should use `health[0].InterfaceVitals[inf.Name]` data instead of `lastStat`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org