You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Antoine Toulme (JIRA)" <ji...@apache.org> on 2010/07/20 01:32:51 UTC
[jira] Created: (BUILDR-483) Write specs for java commands
Write specs for java commands
-----------------------------
Key: BUILDR-483
URL: https://issues.apache.org/jira/browse/BUILDR-483
Project: Buildr
Issue Type: Task
Components: Core features
Affects Versions: 1.4.1
Reporter: Antoine Toulme
Fix For: 1.4.2
The java commands have no coverage.
They are front and central to Buildr. They need to start having coverage as people on Windows tend to suffer from them.
Also, the javac command should use the code from the external.rb file to avoid long command lines. The code between those two files shoud be merged.
Here is the current coverage:
http://buildr.apache.org/coverage/lib-buildr-java-commands_rb.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-483) Write specs for java commands
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903923#action_12903923 ]
Alex Boisvert commented on BUILDR-483:
--------------------------------------
Yeah, it's a metaprogramming fail.
By using Java.java.lang.String, the Java module itself gets shadowed during the execution of the __package__ method. This results in Java.classpath being redefined to a constant/module.
I'm going to try to clean this up.
> Write specs for java commands
> -----------------------------
>
> Key: BUILDR-483
> URL: https://issues.apache.org/jira/browse/BUILDR-483
> Project: Buildr
> Issue Type: Task
> Components: Core features
> Affects Versions: 1.4.1
> Reporter: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: patch_javac_BUILDR-483.patch
>
>
> The java commands have no coverage.
> They are front and central to Buildr. They need to start having coverage as people on Windows tend to suffer from them.
> Also, the javac command should use the code from the external.rb file to avoid long command lines. The code between those two files shoud be merged.
> Here is the current coverage:
> http://buildr.apache.org/coverage/lib-buildr-java-commands_rb.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-483) Write specs for java commands
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903932#action_12903932 ]
Antoine Toulme commented on BUILDR-483:
---------------------------------------
Yes, I have a good coverage of javac to commit.
> Write specs for java commands
> -----------------------------
>
> Key: BUILDR-483
> URL: https://issues.apache.org/jira/browse/BUILDR-483
> Project: Buildr
> Issue Type: Task
> Components: Core features
> Affects Versions: 1.4.1
> Reporter: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: patch_javac_BUILDR-483.patch
>
>
> The java commands have no coverage.
> They are front and central to Buildr. They need to start having coverage as people on Windows tend to suffer from them.
> Also, the javac command should use the code from the external.rb file to avoid long command lines. The code between those two files shoud be merged.
> Here is the current coverage:
> http://buildr.apache.org/coverage/lib-buildr-java-commands_rb.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-483) Write specs for java commands
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903934#action_12903934 ]
Hudson commented on BUILDR-483:
-------------------------------
Integrated in Buildr-ci-build #110 (See [https://hudson.apache.org/hudson/job/Buildr-ci-build/110/])
partial fix for BUILDR-483, with specs for javac
BUILDR-483: Write specs for java commands (Antoine Toulme)
> Write specs for java commands
> -----------------------------
>
> Key: BUILDR-483
> URL: https://issues.apache.org/jira/browse/BUILDR-483
> Project: Buildr
> Issue Type: Task
> Components: Core features
> Affects Versions: 1.4.1
> Reporter: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: patch_javac_BUILDR-483.patch
>
>
> The java commands have no coverage.
> They are front and central to Buildr. They need to start having coverage as people on Windows tend to suffer from them.
> Also, the javac command should use the code from the external.rb file to avoid long command lines. The code between those two files shoud be merged.
> Here is the current coverage:
> http://buildr.apache.org/coverage/lib-buildr-java-commands_rb.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-483) Write specs for java commands
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme updated BUILDR-483:
----------------------------------
Attachment: patch_javac_BUILDR-483.patch
Attached patch for javac. Note that it requires changes in the javac code as the classpath changes when calling javac.
> Write specs for java commands
> -----------------------------
>
> Key: BUILDR-483
> URL: https://issues.apache.org/jira/browse/BUILDR-483
> Project: Buildr
> Issue Type: Task
> Components: Core features
> Affects Versions: 1.4.1
> Reporter: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: patch_javac_BUILDR-483.patch
>
>
> The java commands have no coverage.
> They are front and central to Buildr. They need to start having coverage as people on Windows tend to suffer from them.
> Also, the javac command should use the code from the external.rb file to avoid long command lines. The code between those two files shoud be merged.
> Here is the current coverage:
> http://buildr.apache.org/coverage/lib-buildr-java-commands_rb.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-483) Write specs for java commands
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903936#action_12903936 ]
Hudson commented on BUILDR-483:
-------------------------------
Integrated in Buildr-ci-build-1.9 #6 (See [https://hudson.apache.org/hudson/job/Buildr-ci-build-1.9/6/])
partial fix for BUILDR-483, with specs for javac
BUILDR-483: Write specs for java commands (Antoine Toulme)
> Write specs for java commands
> -----------------------------
>
> Key: BUILDR-483
> URL: https://issues.apache.org/jira/browse/BUILDR-483
> Project: Buildr
> Issue Type: Task
> Components: Core features
> Affects Versions: 1.4.1
> Reporter: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: patch_javac_BUILDR-483.patch
>
>
> The java commands have no coverage.
> They are front and central to Buildr. They need to start having coverage as people on Windows tend to suffer from them.
> Also, the javac command should use the code from the external.rb file to avoid long command lines. The code between those two files shoud be merged.
> Here is the current coverage:
> http://buildr.apache.org/coverage/lib-buildr-java-commands_rb.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-483) Write specs for java commands
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903924#action_12903924 ]
Antoine Toulme commented on BUILDR-483:
---------------------------------------
Ah, cool, I thought it was sun changing the classpath and RJB having bugs over that.
> Write specs for java commands
> -----------------------------
>
> Key: BUILDR-483
> URL: https://issues.apache.org/jira/browse/BUILDR-483
> Project: Buildr
> Issue Type: Task
> Components: Core features
> Affects Versions: 1.4.1
> Reporter: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: patch_javac_BUILDR-483.patch
>
>
> The java commands have no coverage.
> They are front and central to Buildr. They need to start having coverage as people on Windows tend to suffer from them.
> Also, the javac command should use the code from the external.rb file to avoid long command lines. The code between those two files shoud be merged.
> Here is the current coverage:
> http://buildr.apache.org/coverage/lib-buildr-java-commands_rb.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-483) Write specs for java commands
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert updated BUILDR-483:
---------------------------------
Fix Version/s: (was: 1.4.3)
1.4.4
> Write specs for java commands
> -----------------------------
>
> Key: BUILDR-483
> URL: https://issues.apache.org/jira/browse/BUILDR-483
> Project: Buildr
> Issue Type: Task
> Components: Core features
> Affects Versions: 1.4.1
> Reporter: Antoine Toulme
> Fix For: 1.4.4
>
> Attachments: patch_javac_BUILDR-483.patch
>
>
> The java commands have no coverage.
> They are front and central to Buildr. They need to start having coverage as people on Windows tend to suffer from them.
> Also, the javac command should use the code from the external.rb file to avoid long command lines. The code between those two files shoud be merged.
> Here is the current coverage:
> http://buildr.apache.org/coverage/lib-buildr-java-commands_rb.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-483) Write specs for java commands
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903929#action_12903929 ]
Alex Boisvert commented on BUILDR-483:
--------------------------------------
I committed the specs above now that they work (BULDR-499).
Sending spec/java/commands_spec.rb
Transmitting file data .
Committed revision 990493.
Leaving the issue open assuming you want to add more tests.
> Write specs for java commands
> -----------------------------
>
> Key: BUILDR-483
> URL: https://issues.apache.org/jira/browse/BUILDR-483
> Project: Buildr
> Issue Type: Task
> Components: Core features
> Affects Versions: 1.4.1
> Reporter: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: patch_javac_BUILDR-483.patch
>
>
> The java commands have no coverage.
> They are front and central to Buildr. They need to start having coverage as people on Windows tend to suffer from them.
> Also, the javac command should use the code from the external.rb file to avoid long command lines. The code between those two files shoud be merged.
> Here is the current coverage:
> http://buildr.apache.org/coverage/lib-buildr-java-commands_rb.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (BUILDR-483) Write specs for java
commands
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903929#action_12903929 ]
Alex Boisvert edited comment on BUILDR-483 at 8/29/10 1:22 AM:
---------------------------------------------------------------
I committed the specs above now that they work (BUILDR-499).
Sending spec/java/commands_spec.rb
Transmitting file data .
Committed revision 990493.
Leaving the issue open assuming you want to add more tests.
was (Author: boisvert):
I committed the specs above now that they work (BULDR-499).
Sending spec/java/commands_spec.rb
Transmitting file data .
Committed revision 990493.
Leaving the issue open assuming you want to add more tests.
> Write specs for java commands
> -----------------------------
>
> Key: BUILDR-483
> URL: https://issues.apache.org/jira/browse/BUILDR-483
> Project: Buildr
> Issue Type: Task
> Components: Core features
> Affects Versions: 1.4.1
> Reporter: Antoine Toulme
> Fix For: 1.4.2
>
> Attachments: patch_javac_BUILDR-483.patch
>
>
> The java commands have no coverage.
> They are front and central to Buildr. They need to start having coverage as people on Windows tend to suffer from them.
> Also, the javac command should use the code from the external.rb file to avoid long command lines. The code between those two files shoud be merged.
> Here is the current coverage:
> http://buildr.apache.org/coverage/lib-buildr-java-commands_rb.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-483) Write specs for java commands
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert updated BUILDR-483:
---------------------------------
Fix Version/s: 1.4.3
(was: 1.4.2)
> Write specs for java commands
> -----------------------------
>
> Key: BUILDR-483
> URL: https://issues.apache.org/jira/browse/BUILDR-483
> Project: Buildr
> Issue Type: Task
> Components: Core features
> Affects Versions: 1.4.1
> Reporter: Antoine Toulme
> Fix For: 1.4.3
>
> Attachments: patch_javac_BUILDR-483.patch
>
>
> The java commands have no coverage.
> They are front and central to Buildr. They need to start having coverage as people on Windows tend to suffer from them.
> Also, the javac command should use the code from the external.rb file to avoid long command lines. The code between those two files shoud be merged.
> Here is the current coverage:
> http://buildr.apache.org/coverage/lib-buildr-java-commands_rb.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.