You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2015/11/23 23:45:00 UTC
Review Request 40619: SQOOP-2710 Sqoop2: Move user from context
classes to parent TransferableContext
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40619/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2710
https://issues.apache.org/jira/browse/SQOOP-2710
Repository: sqoop-sqoop2
Description
-------
I've moved the user property to parent class as suggested on JIRA.
Diffs
-----
common/src/main/java/org/apache/sqoop/job/etl/DestroyerContext.java 38d94db
common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java 748bdfb
common/src/main/java/org/apache/sqoop/job/etl/InitializerContext.java 7ad0d70
common/src/main/java/org/apache/sqoop/job/etl/LoaderContext.java f0f2e38
common/src/main/java/org/apache/sqoop/job/etl/PartitionerContext.java b39497b
common/src/main/java/org/apache/sqoop/job/etl/TransferableContext.java ad18e29
Diff: https://reviews.apache.org/r/40619/diff/
Testing
-------
Unit tests seems to be passing. I didn't run integration tests, so let's wait on precommit hook.
Thanks,
Jarek Cecho
Re: Review Request 40619: SQOOP-2710 Sqoop2: Move user from context
classes to parent TransferableContext
Posted by Abraham Fine <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40619/#review108335
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Fine
On Nov. 23, 2015, 10:44 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40619/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 10:44 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2710
> https://issues.apache.org/jira/browse/SQOOP-2710
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've moved the user property to parent class as suggested on JIRA.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/job/etl/DestroyerContext.java 38d94db
> common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java 748bdfb
> common/src/main/java/org/apache/sqoop/job/etl/InitializerContext.java 7ad0d70
> common/src/main/java/org/apache/sqoop/job/etl/LoaderContext.java f0f2e38
> common/src/main/java/org/apache/sqoop/job/etl/PartitionerContext.java b39497b
> common/src/main/java/org/apache/sqoop/job/etl/TransferableContext.java ad18e29
>
> Diff: https://reviews.apache.org/r/40619/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing. I didn't run integration tests, so let's wait on precommit hook.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 40619: SQOOP-2710 Sqoop2: Move user from context
classes to parent TransferableContext
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40619/#review107907
-----------------------------------------------------------
Ship it!
Ship It!
- Dian Fu
On Nov. 23, 2015, 10:44 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40619/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 10:44 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2710
> https://issues.apache.org/jira/browse/SQOOP-2710
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've moved the user property to parent class as suggested on JIRA.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/job/etl/DestroyerContext.java 38d94db
> common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java 748bdfb
> common/src/main/java/org/apache/sqoop/job/etl/InitializerContext.java 7ad0d70
> common/src/main/java/org/apache/sqoop/job/etl/LoaderContext.java f0f2e38
> common/src/main/java/org/apache/sqoop/job/etl/PartitionerContext.java b39497b
> common/src/main/java/org/apache/sqoop/job/etl/TransferableContext.java ad18e29
>
> Diff: https://reviews.apache.org/r/40619/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing. I didn't run integration tests, so let's wait on precommit hook.
>
>
> Thanks,
>
> Jarek Cecho
>
>