[GitHub] [flink] 1u0 commented on a change in pull request #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator

[GitBox <gi...@apache.org>]

1u0 commented on a change in pull request #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r319877727
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
 ##########
 @@ -1139,17 +1138,9 @@ public void triggerCheckpointBarrier(
 
 		if (executionState == ExecutionState.RUNNING && invokable != null) {
 
-			// build a local closure
-			final SafetyNetCloseableRegistry safetyNetCloseableRegistry =
-				FileSystemSafetyNet.getSafetyNetCloseableRegistryForThread();
-
 			Runnable runnable = new Runnable() {
 				@Override
 				public void run() {
-					// set safety net from the task's context for checkpointing thread
 
 Review comment:
   My assumption that we are not calling any user code and file system operations in the dispatcher thread anymore. Hence, we can remove the `FileSystemSafetyNet` guard usage there.
   I'm open for corrections, if someone finds this to be not true.
   
   > Do we have a checkstate somewhere for that? Somewhere Inside yield a checkState(isMailboxThread())?
   
   There are checks that you can find in the code (and you should have read it from the preceding PRs).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services