You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/12 00:03:26 UTC
[GitHub] codecov-io edited a comment on issue #5863: [time table] fix
sorting on missing values
codecov-io edited a comment on issue #5863: [time table] fix sorting on missing values
URL: https://github.com/apache/incubator-superset/pull/5863#issuecomment-420466586
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5863?src=pr&el=h1) Report
> Merging [#5863](https://codecov.io/gh/apache/incubator-superset/pull/5863?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01212c3755ba0368ed04e3126268571165639469?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `0%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5863/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5863?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5863 +/- ##
==========================================
+ Coverage 63.69% 63.73% +0.04%
==========================================
Files 374 374
Lines 23325 23326 +1
Branches 2607 2608 +1
==========================================
+ Hits 14857 14867 +10
+ Misses 8455 8446 -9
Partials 13 13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5863?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/visualizations/time\_table.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5863/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90aW1lX3RhYmxlLmpzeA==) | `0% <0%> (ø)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5863/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `81.13% <0%> (+0.75%)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5863/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `55.19% <0%> (+0.87%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5863?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5863?src=pr&el=footer). Last update [01212c3...741d7d8](https://codecov.io/gh/apache/incubator-superset/pull/5863?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org