You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by rsafonseca <gi...@git.apache.org> on 2015/06/14 15:14:20 UTC

[GitHub] cloudstack pull request: Fix findbugs ClassCastException in ScaleS...

GitHub user rsafonseca opened a pull request:

    https://github.com/apache/cloudstack/pull/412

    Fix findbugs ClassCastException in ScaleSystemVMCmd.java

    getDetails() isn't called anywhere in the code, either way, implementation is wrong since details is a Map<String, String> and not a Map<String, Map<String,String>>
    If this piece of could would get run, it would just fail trying to cast String to HashMap<String,String> in line 88

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rsafonseca/cloudstack findbugs29

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/412.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #412
    
----
commit eb2231ad4b174d22ac5c6c43e6014b57e4a94ad5
Author: Rafael da Fonseca <rs...@gmail.com>
Date:   2015-06-14T13:11:16Z

    Fix findbugs ClassCastException in ScaleSystemVMCmd.java
    getDetails() isn't called anywhere in the code, either way, implementation is wrong since details is a Map<String, String> and not a Map<String, Map<String,String>>
    If this piece of could would get run, it would just fail trying to cast String to Map<String,String>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs ClassCastException in ScaleS...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/412


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---