You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/12 08:53:13 UTC

[GitHub] [flink] SteNicholas opened a new pull request #14615: [FLINK-20930][runtime] Remove AbstractExecutionSlotAllocator

SteNicholas opened a new pull request #14615:
URL: https://github.com/apache/flink/pull/14615


   ## What is the purpose of the change
   
   *`DefaultExecutionSlotAllocator` was removed in #14465. Therefore `AbstractExecutionSlotAllocator` is no longer used and could be removed.*
   
   ## Brief change log
   
     - *Remove `AbstractExecutionSlotAllocator`.*
   
   ## Verifying this change
   
     - *Remove `AbstractExecutionSlotAllocatorTest`.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14615: [FLINK-20930][runtime] Remove AbstractExecutionSlotAllocator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14615:
URL: https://github.com/apache/flink/pull/14615#issuecomment-758507929


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 0f247a54f02e27d7274b26783bafcaf940299660 (Fri May 28 07:06:37 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14615: [FLINK-20930][runtime] Remove AbstractExecutionSlotAllocator

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14615:
URL: https://github.com/apache/flink/pull/14615#issuecomment-758507929


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 0f247a54f02e27d7274b26783bafcaf940299660 (Tue Jan 12 08:55:49 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20930).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14615: [FLINK-20930][runtime] Remove AbstractExecutionSlotAllocator

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14615:
URL: https://github.com/apache/flink/pull/14615#issuecomment-758513008


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0f247a54f02e27d7274b26783bafcaf940299660",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0f247a54f02e27d7274b26783bafcaf940299660",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0f247a54f02e27d7274b26783bafcaf940299660 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14615: [FLINK-20930][runtime] Remove AbstractExecutionSlotAllocator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14615:
URL: https://github.com/apache/flink/pull/14615#issuecomment-758513008


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0f247a54f02e27d7274b26783bafcaf940299660",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11914",
       "triggerID" : "0f247a54f02e27d7274b26783bafcaf940299660",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0f247a54f02e27d7274b26783bafcaf940299660 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11914) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann closed pull request #14615: [FLINK-20930][runtime] Remove AbstractExecutionSlotAllocator

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #14615:
URL: https://github.com/apache/flink/pull/14615


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] SteNicholas commented on pull request #14615: [FLINK-20930][runtime] Remove AbstractExecutionSlotAllocator

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14615:
URL: https://github.com/apache/flink/pull/14615#issuecomment-759272794


   @tillrohrmann , could you please help to review this simple pull request?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14615: [FLINK-20930][runtime] Remove AbstractExecutionSlotAllocator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14615:
URL: https://github.com/apache/flink/pull/14615#issuecomment-758513008


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0f247a54f02e27d7274b26783bafcaf940299660",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11914",
       "triggerID" : "0f247a54f02e27d7274b26783bafcaf940299660",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0f247a54f02e27d7274b26783bafcaf940299660 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11914) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org