You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/02/07 15:42:40 UTC

[GitHub] [camel-kafka-connector] omarsmak commented on a change in pull request #85: First step for issue #15

omarsmak commented on a change in pull request #85: First step for issue #15
URL: https://github.com/apache/camel-kafka-connector/pull/85#discussion_r376455873
 
 

 ##########
 File path: core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceTask.java
 ##########
 @@ -42,6 +44,9 @@
 public class CamelSourceTask extends SourceTask {
 
 Review comment:
   Do you think it makes sense if we change the base classes `CamelSinkConnector`, `CamelSourceConnector`, `CamelSinkTask` and `CamelSourceTask` to abstract with abstract methods that need to be overriden? IMHO it makes it easier to follow that need to be overriden 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services