You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/06 14:44:17 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
xiaoxiang781216 opened a new pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487
## Summary
link libs/libxx/libcxxabi instead
## Impact
switch the builtin libcxxabi
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-1017181582
Done, @yamt please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev edited a comment on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
a-lunev edited a comment on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-1017600869
@xiaoxiang781216 I am sorry. I made distclean and rebuilt everything from clean sim:tcpblaster config. Now I can not reproduce that error. I have not saved .config file before distclean. Possibly I had some option enabled that I can not remember now. Or some files were cached on my laptop from the previous builds. I am on Linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei edited a comment on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
gustavonihei edited a comment on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-920254161
I've noticed that our CI does not build `libc++` in any of the selected configurations. Actually `cxxtest` is skipped on `macOS`.
So I've tried building it locally on macOS Big Sur and I couldn't get `libcxx` to build `libcxxtest` defconfig. The `cxxtest` defconfig also fails when changing the C++ library to libcxx.
Relevant information: it is also failing on **master**, so it is not strictly related to this PR.
This is one the errors:
```bash
In file included from ./cxxtest_main.cxx:28:
In file included from /Users/nihei/Projects/NuttX/nuttx/include/libcxx/fstream:183:
/Users/nihei/Projects/NuttX/nuttx/include/libcxx/__availability:187:5: error: "It looks like you're trying to enable vendor availability markup, but you haven't defined the
corresponding macros yet!"
# error "It looks like you're trying to enable vendor availability markup, but you haven't defined the corresponding macros yet!"
^
1 error generated.
ERROR: c++ failed: 1
command: c++ -MT ./cxxtest_main.cxx.Users.nihei.Projects.NuttX.apps.testing.cxxtest.o -M '-Wall' '-Wshadow' '-Wundef' '-g' '-fno-builtin' '-nostdinc++' '-fvisibility=hidden' '-fno-common' '-isystem' '/Users/nihei/Projects/NuttX/nuttx/include/libcxx' '-isystem' '/Users/nihei/Projects/NuttX/nuttx/include' '-D__NuttX__' '-U_AIX' '-U_WIN32' '-U__APPLE__' '-U__FreeBSD__' '-U__NetBSD__' '-U__linux__' '-U__sun__' '-U__unix__' '-D__KERNEL__' '-pipe' '-fshort-wchar' '-std=c++17' '-DLIBCXX_BUILDING_LIBCXXABI' '-I' '/Users/nihei/Projects/NuttX/apps/include' ./cxxtest_main.cxx
```
I've tried the following patch, but to no success:
```patch
diff --git a/libs/libxx/libcxxmini.defs b/libs/libxx/libcxxmini.defs
index 2624a4534c..4e780e303a 100644
--- a/libs/libxx/libcxxmini.defs
+++ b/libs/libxx/libcxxmini.defs
@@ -35,5 +35,7 @@ ifneq ($(CONFIG_XTENSA_TOOLCHAIN_XCC), y)
libxx_newa.cxx_CXXFLAGS += -Wno-missing-exception-spec
endif
+CXXFLAGS += ${shell $(DEFINE) "$(CC)" _LIBCXXABI_BUILDING_LIBRARY}
+
DEPPATH += --dep-path libcxxmini
VPATH += libcxxmini
```
This is the version of the `clang c++` compiler:
```
Apple clang version 12.0.0 (clang-1200.0.32.29)
Target: x86_64-apple-darwin20.3.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-1017167902
> > arch/sim: Don't add -lc++abi to STDLIBS
>
> it's probably ok, but i'm not sure if i understand the motivation.
>
We use libcxx library from:
https://github.com/apache/incubator-nuttx/blob/master/libs/libxx/libcxx.defs
It's also reasonable to use libcxxabi from:
https://github.com/apache/incubator-nuttx/blob/master/libs/libxx/libcxxabi.defs
to keep both in sync.
> > boards/sim: Remove the check CONFIG_LIBCXX before build up_macho_init.c
>
> it can cause assertion failure here for non-C++ configurations.
>
> https://github.com/apache/incubator-nuttx/blob/ea6141e01b1e2953cbdb36805b7eeeb877bdb673/arch/sim/src/sim/up_macho_init.c#L63
>
The assert is wrong, why assume C++ program must have global variables with constructor?
>
> maybe check HAVE_CXXINITIALIZE instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev commented on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
a-lunev commented on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-1017565855
> Ok, let's guard with HAVE_CXXINITIALIZE instead
@xiaoxiang781216 I have caught the following error (sim:tcpblaster config) after pulling the current state of the master branch:
`nuttx/libs/libc/sched/task_startup.c:64: undefined reference to `cxx_initialize'`
I suppose commit 67fc54dd3d49aa909624d77cea763f94494f275c affected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-1016738852
@yamt could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-920254161
I've noticed that our CI does not build `libc++` in any of the selected configurations. Actually `cxxtest` is skipped on `macOS`.
So I've tried building it locally on macOS Big Sur and I couldn't get `libcxx` to build `libcxxtest` defconfig. The `cxxtest` defconfig also fails when changing the C++ library to libcxx. This is one the errors:
```bash
In file included from ./cxxtest_main.cxx:28:
In file included from /Users/nihei/Projects/NuttX/nuttx/include/libcxx/fstream:183:
/Users/nihei/Projects/NuttX/nuttx/include/libcxx/__availability:187:5: error: "It looks like you're trying to enable vendor availability markup, but you haven't defined the
corresponding macros yet!"
# error "It looks like you're trying to enable vendor availability markup, but you haven't defined the corresponding macros yet!"
^
1 error generated.
ERROR: c++ failed: 1
command: c++ -MT ./cxxtest_main.cxx.Users.nihei.Projects.NuttX.apps.testing.cxxtest.o -M '-Wall' '-Wshadow' '-Wundef' '-g' '-fno-builtin' '-nostdinc++' '-fvisibility=hidden' '-fno-common' '-isystem' '/Users/nihei/Projects/NuttX/nuttx/include/libcxx' '-isystem' '/Users/nihei/Projects/NuttX/nuttx/include' '-D__NuttX__' '-U_AIX' '-U_WIN32' '-U__APPLE__' '-U__FreeBSD__' '-U__NetBSD__' '-U__linux__' '-U__sun__' '-U__unix__' '-D__KERNEL__' '-pipe' '-fshort-wchar' '-std=c++17' '-DLIBCXX_BUILDING_LIBCXXABI' '-I' '/Users/nihei/Projects/NuttX/apps/include' ./cxxtest_main.cxx
```
I've tried the following patch, but to no success:
```patch
diff --git a/libs/libxx/libcxxmini.defs b/libs/libxx/libcxxmini.defs
index 2624a4534c..4e780e303a 100644
--- a/libs/libxx/libcxxmini.defs
+++ b/libs/libxx/libcxxmini.defs
@@ -35,5 +35,7 @@ ifneq ($(CONFIG_XTENSA_TOOLCHAIN_XCC), y)
libxx_newa.cxx_CXXFLAGS += -Wno-missing-exception-spec
endif
+CXXFLAGS += ${shell $(DEFINE) "$(CC)" _LIBCXXABI_BUILDING_LIBRARY}
+
DEPPATH += --dep-path libcxxmini
VPATH += libcxxmini
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-1017177279
Ok, let's guard with HAVE_CXXINITIALIZE instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei edited a comment on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
gustavonihei edited a comment on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-920254161
I've noticed that our CI does not build `libc++` in any of the selected configurations. Actually `cxxtest` is skipped on `macOS`.
So I've tried building it locally on macOS Big Sur and I couldn't get `libcxx` to build `libcxxtest` defconfig. The `cxxtest` defconfig also fails when changing the C++ library to libcxx.
Relevant information: it is also failing on **master**, so it is not strictly related to this PR.
This is one the errors:
```bash
In file included from ./cxxtest_main.cxx:28:
In file included from /Users/nihei/Projects/NuttX/nuttx/include/libcxx/fstream:183:
/Users/nihei/Projects/NuttX/nuttx/include/libcxx/__availability:187:5: error: "It looks like you're trying to enable vendor availability markup, but you haven't defined the
corresponding macros yet!"
# error "It looks like you're trying to enable vendor availability markup, but you haven't defined the corresponding macros yet!"
^
1 error generated.
ERROR: c++ failed: 1
command: c++ -MT ./cxxtest_main.cxx.Users.nihei.Projects.NuttX.apps.testing.cxxtest.o -M '-Wall' '-Wshadow' '-Wundef' '-g' '-fno-builtin' '-nostdinc++' '-fvisibility=hidden' '-fno-common' '-isystem' '/Users/nihei/Projects/NuttX/nuttx/include/libcxx' '-isystem' '/Users/nihei/Projects/NuttX/nuttx/include' '-D__NuttX__' '-U_AIX' '-U_WIN32' '-U__APPLE__' '-U__FreeBSD__' '-U__NetBSD__' '-U__linux__' '-U__sun__' '-U__unix__' '-D__KERNEL__' '-pipe' '-fshort-wchar' '-std=c++17' '-DLIBCXX_BUILDING_LIBCXXABI' '-I' '/Users/nihei/Projects/NuttX/apps/include' ./cxxtest_main.cxx
```
I've tried the following patch, but to no success:
```patch
diff --git a/libs/libxx/libcxxmini.defs b/libs/libxx/libcxxmini.defs
index 2624a4534c..4e780e303a 100644
--- a/libs/libxx/libcxxmini.defs
+++ b/libs/libxx/libcxxmini.defs
@@ -35,5 +35,7 @@ ifneq ($(CONFIG_XTENSA_TOOLCHAIN_XCC), y)
libxx_newa.cxx_CXXFLAGS += -Wno-missing-exception-spec
endif
+CXXFLAGS += ${shell $(DEFINE) "$(CC)" _LIBCXXABI_BUILDING_LIBRARY}
+
DEPPATH += --dep-path libcxxmini
VPATH += libcxxmini
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-920453958
how about finishing https://github.com/apache/incubator-nuttx/pull/2063 before making changes like this without testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-1017175259
> > > arch/sim: Don't add -lc++abi to STDLIBS
> >
> >
> > it's probably ok, but i'm not sure if i understand the motivation.
>
> We use libcxx library from: https://github.com/apache/incubator-nuttx/blob/master/libs/libxx/libcxx.defs It's also reasonable to use libcxxabi from: https://github.com/apache/incubator-nuttx/blob/master/libs/libxx/libcxxabi.defs to keep both in sync.
ok.
>
> > > boards/sim: Remove the check CONFIG_LIBCXX before build up_macho_init.c
> >
> >
> > it can cause assertion failure here for non-C++ configurations.
> > https://github.com/apache/incubator-nuttx/blob/ea6141e01b1e2953cbdb36805b7eeeb877bdb673/arch/sim/src/sim/up_macho_init.c#L63
>
> The assert is wrong, why assume C++ program must have global variables with constructor?
maybe you are right. but even if the assertion is fixed, i still feel uneasy to enable this hack unconditionally.
>
> > maybe check HAVE_CXXINITIALIZE instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev commented on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
a-lunev commented on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-1017600869
@xiaoxiang781216 I am sorry. I made distclean and rebuilt everything from clean sim:tcpblaster config. Now I can not reproduce that error. I have not saved .config file before distclean. Possibly I had some option enabled that I can not remember now. Or some files were cached on my laptop from the old state. I am on Linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-1017159328
> arch/sim: Don't add -lc++abi to STDLIBS
it's probably ok, but i'm not sure if i understand the motivation.
> boards/sim: Remove the check CONFIG_LIBCXX before build up_macho_init.c
it can cause assertion failure here for non-C++ configurations.
https://github.com/apache/incubator-nuttx/blob/ea6141e01b1e2953cbdb36805b7eeeb877bdb673/arch/sim/src/sim/up_macho_init.c#L63
maybe check HAVE_CXXINITIALIZE instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei edited a comment on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
gustavonihei edited a comment on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-920254161
I've noticed that our CI does not build `libc++` in any of the selected configurations. Actually `cxxtest` is skipped on `macOS`.
So I've tried building it locally on macOS Big Sur and I couldn't get `libcxx` to build `libcxxtest` defconfig. The `cxxtest` defconfig also fails when changing the C++ library to libcxx.
Relevant information: it is also failing on **master**, so it is not strictly related to this PR.
This is one of the errors:
```bash
In file included from ./cxxtest_main.cxx:28:
In file included from /Users/nihei/Projects/NuttX/nuttx/include/libcxx/fstream:183:
/Users/nihei/Projects/NuttX/nuttx/include/libcxx/__availability:187:5: error: "It looks like you're trying to enable vendor availability markup, but you haven't defined the
corresponding macros yet!"
# error "It looks like you're trying to enable vendor availability markup, but you haven't defined the corresponding macros yet!"
^
1 error generated.
ERROR: c++ failed: 1
command: c++ -MT ./cxxtest_main.cxx.Users.nihei.Projects.NuttX.apps.testing.cxxtest.o -M '-Wall' '-Wshadow' '-Wundef' '-g' '-fno-builtin' '-nostdinc++' '-fvisibility=hidden' '-fno-common' '-isystem' '/Users/nihei/Projects/NuttX/nuttx/include/libcxx' '-isystem' '/Users/nihei/Projects/NuttX/nuttx/include' '-D__NuttX__' '-U_AIX' '-U_WIN32' '-U__APPLE__' '-U__FreeBSD__' '-U__NetBSD__' '-U__linux__' '-U__sun__' '-U__unix__' '-D__KERNEL__' '-pipe' '-fshort-wchar' '-std=c++17' '-DLIBCXX_BUILDING_LIBCXXABI' '-I' '/Users/nihei/Projects/NuttX/apps/include' ./cxxtest_main.cxx
```
I've tried the following patch, but to no success:
```patch
diff --git a/libs/libxx/libcxxmini.defs b/libs/libxx/libcxxmini.defs
index 2624a4534c..4e780e303a 100644
--- a/libs/libxx/libcxxmini.defs
+++ b/libs/libxx/libcxxmini.defs
@@ -35,5 +35,7 @@ ifneq ($(CONFIG_XTENSA_TOOLCHAIN_XCC), y)
libxx_newa.cxx_CXXFLAGS += -Wno-missing-exception-spec
endif
+CXXFLAGS += ${shell $(DEFINE) "$(CC)" _LIBCXXABI_BUILDING_LIBRARY}
+
DEPPATH += --dep-path libcxxmini
VPATH += libcxxmini
```
This is the version of the `clang c++` compiler:
```
Apple clang version 12.0.0 (clang-1200.0.32.29)
Target: x86_64-apple-darwin20.3.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-1017581523
Yes, look like we need to compile libs/libc/sched/cxx_initialize_macho.c on macOS always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-1018296636
> The assert is wrong, why assume C++ program must have global variables with constructor?
https://github.com/apache/incubator-nuttx/pull/5301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org