You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mugdha Varadkar <mu...@gmail.com> on 2023/12/14 05:53:10 UTC
Re: Review Request 74728: RANGER-4513: Policy listing page experiences an reset to Access tab when attempting to filter the service and zone dropdown options.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74728/#review226049
-----------------------------------------------------------
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx
Line 218 (original), 218 (patched)
<https://reviews.apache.org/r/74728/#comment314372>
We have below solutions to handle this,
1) We can use hideSelectedOptions props of react-select to hide the selected option from the menu so that onChange is not triggered for the same value.
2) Update the logic in onChange to check if the selected value does match the currently selected value, then simply do nothing
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx
Line 232 (original), 240 (patched)
<https://reviews.apache.org/r/74728/#comment314373>
Please refer above review comments from above.
- Mugdha Varadkar
On Nov. 9, 2023, 9:46 a.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74728/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2023, 9:46 a.m.)
>
>
> Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
>
>
> Bugs: RANGER-4513
> https://issues.apache.org/jira/browse/RANGER-4513
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The policy listing page experiences an unexpected reset when attempting to filter the service and zone dropdown options.
>
> Steps to Reproduce:
> 1)Navigate to the "hive" policy listing page.
> 2)Goto Masking tab
> 3)Select the "Service" dropdown to filter policies based on a specific service.
> 4)Select the "Zone" dropdown to filter policies based on specific zone.
> 5)Observe that the page resets to the default "Access" tab
>
> Expected Behavior:
>
> The page should retain the selected tab when filtering the service and zone dropdown.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx 44d9f1da9
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx d4dbc57d1
>
>
> Diff: https://reviews.apache.org/r/74728/diff/1/
>
>
> Testing
> -------
>
> Testing is in progress
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74728: RANGER-4513: Policy listing page experiences an reset to Access tab when attempting to filter the service and zone dropdown options.
Posted by Brijesh Bhalala <br...@gmail.com>.
> On Dec. 14, 2023, 5:53 a.m., Mugdha Varadkar wrote:
> > security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx
> > Line 218 (original), 218 (patched)
> > <https://reviews.apache.org/r/74728/diff/1/?file=2283032#file2283032line218>
> >
> > We have below solutions to handle this,
> >
> > 1) We can use hideSelectedOptions props of react-select to hide the selected option from the menu so that onChange is not triggered for the same value.
> >
> > 2) Update the logic in onChange to check if the selected value does match the currently selected value, then simply do nothing
I have updated this in latest patch
- Brijesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74728/#review226049
-----------------------------------------------------------
On Dec. 14, 2023, 10:26 a.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74728/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2023, 10:26 a.m.)
>
>
> Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
>
>
> Bugs: RANGER-4513
> https://issues.apache.org/jira/browse/RANGER-4513
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The policy listing page experiences an unexpected reset when attempting to filter the service and zone dropdown options.
>
> Steps to Reproduce:
> 1)Navigate to the "hive" policy listing page.
> 2)Goto Masking tab
> 3)Select the "Service" dropdown to filter policies based on a specific service.
> 4)Select the "Zone" dropdown to filter policies based on specific zone.
> 5)Observe that the page resets to the default "Access" tab
>
> Expected Behavior:
>
> The page should retain the selected tab when filtering the service and zone dropdown.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx 7c6b1c19b
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx 860b1ab78
>
>
> Diff: https://reviews.apache.org/r/74728/diff/2/
>
>
> Testing
> -------
>
> Testing is in progress
>
>
> Thanks,
>
> Brijesh Bhalala
>
>