[GitHub] [hudi] danny0405 commented on a diff in pull request #8548: [WIP][HUDI-6126] Fix test `testInsertDatasetWIthTimelineTimezoneUTC`

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8548:
URL: https://github.com/apache/hudi/pull/8548#discussion_r1174491186


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieSparkSqlWriter.scala:
##########
@@ -1232,6 +1232,7 @@ class TestHoodieSparkSqlWriter {
     val beforeWriteInstant = Instant.now()
 
     // set local timezone to America/Los_Angeles(UTC-7)
+    val defaultTimezone = TimeZone.getDefault
     TimeZone.setDefault(TimeZone.getTimeZone("America/Los_Angeles"))

Review Comment:
   Okay, my fault, we should never allows setting timezone explicitly in the code, the whole JVM process could be affected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org