[GitHub] [spark] rashtao commented on a change in pull request #32299: Allow custom JsonGenerator in JacksonGenerator

[GitBox <gi...@apache.org>]

rashtao commented on a change in pull request #32299:
URL: https://github.com/apache/spark/pull/32299#discussion_r619150925



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
##########
@@ -37,8 +37,18 @@ import org.apache.spark.sql.types._
  */
 private[sql] class JacksonGenerator(

Review comment:
       As far I can see datasources are sometimes implemented under `org.apache.spark.sql`, thus accessing private and protected members, ie. https://github.com/datastax/spark-cassandra-connector/tree/master/connector/src/main/scala/org/apache/spark/sql/cassandra
   Of course relying on private API could lead to unpredictable breaking changes. Ideally `JacksonParser` and `JacksonGenerator` could evolve to a public API usable by any binary dataformat implementation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org