[jira] [Commented] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

["Chula Lathong (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401479#comment-15401479 ] 

Chula Lathong commented on OFBIZ-7801:
--------------------------------------

Hi Jacques Le Roux, I have not created this patch by referring to the patch in OFBIZ-4850.
But I relate this issue with OFBIZ-4850 because, I see that they are similar issues. Are there anything I should edit? 
Thank you.

> Duplicate invoice tax by using "Add Tax" button.
> ------------------------------------------------
>
>                 Key: OFBIZ-7801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7801
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Chula Lathong
>         Attachments: OFBIZ-7801.patch
>
>
> A bug occurs when users generate tax by click the "Add Tax" button.
> If an invoice has tax in invoice items list, the system will generate tax of tax invoice items .
> The problem is the system should not generate tax of tax invoice items.
> This patch shall change process of "Add Tax" service to remove all tax invoice items before generating new tax invoice items.
> And I have a suggestion about "Add Tax" service, for each invoice the invoice items it is possible to have the product item that has productId and no productId.
> But in the "Add Tax" service they have check on each product item should have a productId if it's not the sevice will return error no productId.
> So, I think the service should ignore to calculate tax on invoice item that's not has a productId link.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)