You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Neal Richardson (Jira)" <ji...@apache.org> on 2022/07/15 15:33:00 UTC

[jira] [Assigned] (ARROW-14332) [C++] Rename type traits utilities to improve semantic consistency

     [ https://issues.apache.org/jira/browse/ARROW-14332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Neal Richardson reassigned ARROW-14332:
---------------------------------------

    Fix Version/s:     (was: 9.0.0)
         Assignee:     (was: Eduardo Ponce)
           Labels: stop type  (was: type)

This issue has been inactive for 3 months, so it has been unassigned and marked as unstarted. If you are still working on this, feel free to reassign yourself and resume progress.

> [C++] Rename type traits utilities to improve semantic consistency
> ------------------------------------------------------------------
>
>                 Key: ARROW-14332
>                 URL: https://issues.apache.org/jira/browse/ARROW-14332
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Eduardo Ponce
>            Priority: Minor
>              Labels: stop, type
>
> There are semantic differences between *enable_ifs-related* utils and *is_xxx* functions with the same name. For example, *is_binary_like* [here|https://github.com/apache/arrow/blob/master/cpp/src/arrow/type_traits.h#L596] != [here|https://github.com/apache/arrow/blob/master/cpp/src/arrow/type_traits.h#L924]. The former includes binary only and the latter binary/string types.
> Also, the *_like* suffix seems unwarranted as they always refer to binary or string.
> Also, the *is_fixed_size_binary* includes both _FixedSizeBinaryType_ and {_}DecimalXXXType{_}. A better name is *is_base_fixed_size_binary* to match how binary/string utils are used.
> {_}Note{_}: There might be other inconsistencies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)