You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/02 12:02:02 UTC

[GitHub] [kafka] LMnet opened a new pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

LMnet opened a new pull request #9245:
URL: https://github.com/apache/kafka/pull/9245


   This is a build fix after [KAFKA-10020](https://github.com/apache/kafka/pull/8955). 
   
   It looks like scala 2.12 and 2.13 have different import shadowing algorithms. On 2.12 explicit import of `org.apache.kafka.streams.scala.serialization.Serdes` has less priority than `org.apache.kafka.streams.scala.Serdes` in tests inside `org.apache.kafka.streams.scala` package.
   
   I fixed this by using explicit renaming in import.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] vvcephei commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9245:
URL: https://github.com/apache/kafka/pull/9245#issuecomment-685893473


   Test this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] LMnet commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

Posted by GitBox <gi...@apache.org>.
LMnet commented on pull request #9245:
URL: https://github.com/apache/kafka/pull/9245#issuecomment-685863455


   @ijuma kafka users will not be affected by this, because shadowing conflict occurs only in the kafka internal packages. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] vvcephei commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9245:
URL: https://github.com/apache/kafka/pull/9245#issuecomment-685893240


   Retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] vvcephei commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9245:
URL: https://github.com/apache/kafka/pull/9245#issuecomment-685897537


   Ok, I just merged this. Sorry for breaking the build, all. And thanks @mumrah for getting the PR builds working again!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9245:
URL: https://github.com/apache/kafka/pull/9245#issuecomment-685846486


   We should merge this to fix the build, but it seems suboptimal for our users too. cc @guozhangwang @mjsax @vvcephei 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] chia7712 commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9245:
URL: https://github.com/apache/kafka/pull/9245#issuecomment-685713654


   > It looks like scala 2.12 and 2.13 have different import shadowing algorithms. On 2.12 explicit import of org.apache.kafka.streams.scala.serialization.Serdes has less priority than org.apache.kafka.streams.scala.Serdes in tests inside org.apache.kafka.streams.scala package.
   
   related PR: https://github.com/scala/scala/pull/6589


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] vvcephei commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9245:
URL: https://github.com/apache/kafka/pull/9245#issuecomment-685895615


   Thanks for the reviews, all. I also took a look at the builds, and they seem fine apart from the flaky tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] vvcephei merged pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

Posted by GitBox <gi...@apache.org>.
vvcephei merged pull request #9245:
URL: https://github.com/apache/kafka/pull/9245


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org