You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/02 09:27:16 UTC
[GitHub] [hadoop-ozone] sadanand48 opened a new pull request #1006: HDDS-3699.Change write chunk failure logging level to INFO in BlockOutputStream.
sadanand48 opened a new pull request #1006:
URL: https://github.com/apache/hadoop-ozone/pull/1006
## What changes were proposed in this pull request?
Changing logging level for a write chunk failure to INFO in BlockOutputStream.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3699
## How was this patch tested?
not required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1006: HDDS-3699. Change write chunk failure logging level to ERROR in BlockOutputStream.
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1006:
URL: https://github.com/apache/hadoop-ozone/pull/1006#issuecomment-651669592
Ups, we got green build, but we forgot to merge it. Sorry for that. Doing it now. Thanks for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bshashikant edited a comment on pull request #1006: HDDS-3699. Change write chunk failure logging level to ERROR in BlockOutputStream.
Posted by GitBox <gi...@apache.org>.
bshashikant edited a comment on pull request #1006:
URL: https://github.com/apache/hadoop-ozone/pull/1006#issuecomment-638723740
> Thanks to open this issue @sadanand48. Unfortunately I don't have the context? (How did you notice this? What was the problem? How can I reproduce it?).
>
> Therefore, I have a few questions to understand this patch:
>
> Why don't we use `ERROR`, why do we need `INFO`?
>
> What is the expected number of log messages in case of any error? (Let's say disk is not writable). Is it possible to a lot of INFO message?
>
> The exception seems to be propagated. Is it logged on higher level?
It should be logged in error level. It will be useful to log this error for debug purpose. The putBlock/watchForCommit exceptions are logged not the write chunk failures on higher level.
If the disk is bad, its possible to have lot of error messages based on no of clients wriing on the disk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek merged pull request #1006: HDDS-3699. Change write chunk failure logging level to ERROR in BlockOutputStream.
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1006:
URL: https://github.com/apache/hadoop-ozone/pull/1006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bshashikant commented on pull request #1006: HDDS-3699. Change write chunk failure logging level to INFO in BlockOutputStream.
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1006:
URL: https://github.com/apache/hadoop-ozone/pull/1006#issuecomment-638723740
> Thanks to open this issue @sadanand48. Unfortunately I don't have the context? (How did you notice this? What was the problem? How can I reproduce it?).
>
> Therefore, I have a few questions to understand this patch:
>
> Why don't we use `ERROR`, why do we need `INFO`?
>
> What is the expected number of log messages in case of any error? (Let's say disk is not writable). Is it possible to a lot of INFO message?
>
> The exception seems to be propagated. Is it logged on higher level?
It should be logged in error level. It will be useful to log this error for debug purpose. The putBlock/watchForCommit exceptions are logged not the write chunk failures on higher level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1006: HDDS-3699.Change write chunk failure logging level to INFO in BlockOutputStream.
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1006:
URL: https://github.com/apache/hadoop-ozone/pull/1006#issuecomment-637423538
Thanks to open this issue @sadanand48. Unfortunately I don't have the context? (How did you notice this? What was the problem? How can I reproduce it?).
Therefore, I have a few questions to understand this patch:
Why don't we use `ERROR`, why do we need `INFO`?
What is the expected number of log messages in case of any error? (Let's say disk is not writable). Is it possible to a lot of INFO message?
The exception seems to be propagated. Is it logged on higher level?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org