You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/30 07:59:46 UTC

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #915: fix: typo `scheme validate fail` should be `schema validate failed`

nic-chen opened a new pull request #915:
URL: https://github.com/apache/apisix-dashboard/pull/915


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   fix  #914
   typo:  `scheme validate fail` -> `schema validate failed`
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #915: fix: typo `scheme validate fail` should be `schema validate failed`

Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #915:
URL: https://github.com/apache/apisix-dashboard/pull/915#discussion_r532412138



##########
File path: api/internal/core/store/validate.go
##########
@@ -123,25 +123,25 @@ func cHashKeySchemaCheck(upstream *entity.UpstreamDef) error {
 	if upstream.HashOn == "vars" {
 		schemaDef = conf.Schema.Get("main.upstream_hash_vars_schema").String()
 		if schemaDef == "" {
-			return fmt.Errorf("scheme validate failed: schema not found, patch: main.upstream_hash_vars_schema")
+			return fmt.Errorf("schema validate faileded: schema not found, patch: main.upstream_hash_vars_schema")

Review comment:
       ditto




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #915: fix: typo `scheme validate fail` should be `schema validate failed`

Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #915:
URL: https://github.com/apache/apisix-dashboard/pull/915#discussion_r532411997



##########
File path: api/internal/core/store/validate.go
##########
@@ -77,8 +77,8 @@ type APISIXJsonSchemaValidator struct {
 func NewAPISIXJsonSchemaValidator(jsonPath string) (Validator, error) {
 	schemaDef := conf.Schema.Get(jsonPath).String()
 	if schemaDef == "" {
-		log.Warnf("scheme validate failed: schema not found, path: %s", jsonPath)
-		return nil, fmt.Errorf("scheme validate failed: schema not found, path: %s", jsonPath)
+		log.Warnf("schema validate faileded: schema not found, path: %s", jsonPath)
+		return nil, fmt.Errorf("schema validate faileded: schema not found, path: %s", jsonPath)

Review comment:
       `faileded` -> `failed`

##########
File path: api/internal/core/store/validate.go
##########
@@ -123,25 +123,25 @@ func cHashKeySchemaCheck(upstream *entity.UpstreamDef) error {
 	if upstream.HashOn == "vars" {
 		schemaDef = conf.Schema.Get("main.upstream_hash_vars_schema").String()
 		if schemaDef == "" {
-			return fmt.Errorf("scheme validate failed: schema not found, patch: main.upstream_hash_vars_schema")
+			return fmt.Errorf("schema validate faileded: schema not found, patch: main.upstream_hash_vars_schema")

Review comment:
       dido




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #915: fix: typo `scheme validate fail` should be `schema validate failed`

Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #915:
URL: https://github.com/apache/apisix-dashboard/pull/915#discussion_r532469083



##########
File path: api/internal/core/store/validate.go
##########
@@ -77,8 +77,8 @@ type APISIXJsonSchemaValidator struct {
 func NewAPISIXJsonSchemaValidator(jsonPath string) (Validator, error) {
 	schemaDef := conf.Schema.Get(jsonPath).String()
 	if schemaDef == "" {
-		log.Warnf("scheme validate failed: schema not found, path: %s", jsonPath)
-		return nil, fmt.Errorf("scheme validate failed: schema not found, path: %s", jsonPath)
+		log.Warnf("schema validate faileded: schema not found, path: %s", jsonPath)
+		return nil, fmt.Errorf("schema validate faileded: schema not found, path: %s", jsonPath)

Review comment:
       fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis merged pull request #915: fix: typo `scheme validate fail` should be `schema validate failed`

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #915:
URL: https://github.com/apache/apisix-dashboard/pull/915


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #915: fix: typo `scheme validate fail` should be `schema validate failed`

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #915:
URL: https://github.com/apache/apisix-dashboard/pull/915#issuecomment-735621795


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/915?src=pr&el=h1) Report
   > Merging [#915](https://codecov.io/gh/apache/apisix-dashboard/pull/915?src=pr&el=desc) (93f1b3b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/038c078eb5fb9b39642ff47d0456538a652ae614?el=desc) (038c078) will **not change** coverage.
   > The diff coverage is `18.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/915/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/915?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #915   +/-   ##
   =======================================
     Coverage   43.03%   43.03%           
   =======================================
     Files          18       18           
     Lines        1271     1271           
   =======================================
     Hits          547      547           
     Misses        632      632           
     Partials       92       92           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/915?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/915/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `55.07% <18.75%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/915?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/915?src=pr&el=footer). Last update [038c078...93f1b3b](https://codecov.io/gh/apache/apisix-dashboard/pull/915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #915: fix: typo `scheme validate fail` should be `schema validate failed`

Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #915:
URL: https://github.com/apache/apisix-dashboard/pull/915#discussion_r532469175



##########
File path: api/internal/core/store/validate.go
##########
@@ -123,25 +123,25 @@ func cHashKeySchemaCheck(upstream *entity.UpstreamDef) error {
 	if upstream.HashOn == "vars" {
 		schemaDef = conf.Schema.Get("main.upstream_hash_vars_schema").String()
 		if schemaDef == "" {
-			return fmt.Errorf("scheme validate failed: schema not found, patch: main.upstream_hash_vars_schema")
+			return fmt.Errorf("schema validate faileded: schema not found, patch: main.upstream_hash_vars_schema")

Review comment:
       fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org