You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2013/10/15 00:20:03 UTC

Review Request 14634: SAMZA-57

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14634/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

fix NPE in serialized key value store


Diffs
-----

  samza-core/src/main/scala/org/apache/samza/serializers/IntegerSerde.scala 3f219c8f4c51581bcca5dde30b3ff86912535753 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala 7b4db82575ffe22df35ee5ce17b8ae842d3e5d05 
  samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 0be0722db5cdbba900b42895508d2529fb81d7d0 
  samza-kv/src/test/scala/org/apache/samza/storage/kv/TestSerializedKeyValueStore.scala PRE-CREATION 

Diff: https://reviews.apache.org/r/14634/diff/


Testing
-------


Thanks,

Chris Riccomini

Re: Review Request 14634: SAMZA-57

Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14634/
-----------------------------------------------------------

(Updated Oct. 15, 2013, 5:34 p.m.)


Review request for samza.


Repository: samza


Description (updated)
-------

removing empty serialized kv store test since we are testing in the TestKeyValueStore class instead.


fix NPE in serialized key value store


Diffs (updated)
-----

  samza-core/src/main/scala/org/apache/samza/serializers/IntegerSerde.scala 3f219c8f4c51581bcca5dde30b3ff86912535753 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala 7b4db82575ffe22df35ee5ce17b8ae842d3e5d05 
  samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 0be0722db5cdbba900b42895508d2529fb81d7d0 

Diff: https://reviews.apache.org/r/14634/diff/


Testing
-------


Thanks,

Chris Riccomini