You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "aherbert (via GitHub)" <gi...@apache.org> on 2023/10/20 08:07:54 UTC
[PR] Update DoubleFormat to state it is based on Double.toString. [commons-text]
aherbert opened a new pull request, #467:
URL: https://github.com/apache/commons-text/pull/467
This changes the tests to fix some incompatibility between the reference DecimalFormat class and DoubleFormat when:
- The output string has a trailing .0 due to rounding (which may be omitted by DecimalFormat).
- The Double.toString output has fewer chars than the full precision output from DecimalFormat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update DoubleFormat to state it is based on Double.toString. [commons-text]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #467:
URL: https://github.com/apache/commons-text/pull/467#issuecomment-1772477794
TY @aherbert !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update DoubleFormat to state it is based on Double.toString. [commons-text]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #467:
URL: https://github.com/apache/commons-text/pull/467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update DoubleFormat to state it is based on Double.toString. [commons-text]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #467:
URL: https://github.com/apache/commons-text/pull/467#issuecomment-1772277622
## [Codecov](https://app.codecov.io/gh/apache/commons-text/pull/467?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#467](https://app.codecov.io/gh/apache/commons-text/pull/467?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (22c0bb1) into [master](https://app.codecov.io/gh/apache/commons-text/commit/3bb3568a12f24c7b38e21b2042d77423f05ce7c3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3bb3568) will **not change** coverage.
> Report is 2 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #467 +/- ##
=========================================
Coverage 96.99% 96.99%
Complexity 2342 2342
=========================================
Files 86 86
Lines 5792 5792
Branches 938 938
=========================================
Hits 5618 5618
Misses 95 95
Partials 79 79
```
| [Files](https://app.codecov.io/gh/apache/commons-text/pull/467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/commons/text/numbers/DoubleFormat.java](https://app.codecov.io/gh/apache/commons-text/pull/467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvdGV4dC9udW1iZXJzL0RvdWJsZUZvcm1hdC5qYXZh) | `100.00% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org