You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ram Mettu (Code Review)" <ge...@cloudera.org> on 2017/02/20 05:17:47 UTC

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Ram Mettu has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6078

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................

KUDU-1890 Allow renaming of primary key column

Removed the checks preventing primary key column name
to be renamed and added test cases.

Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/client-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet.cc
4 files changed, 50 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/6078/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


KUDU-1890 Allow renaming of primary key column

Removed the checks preventing renaming of primary key
columns, added test cases and updated documents.

Testing: Ran a loop of 100 alter_table-randomized-test.cc test
successfully which includes modification to rename a primary key
and non-primary columns.

Addressed code review comments

Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Reviewed-on: http://gerrit.cloudera.org:8080/6078
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M docs/developing.adoc
M docs/known_issues.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/client-test.cc
M src/kudu/client/table_alterer-internal.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet.cc
13 files changed, 219 insertions(+), 48 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 14
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 3:

(4 comments)

Based on my experience in the alter code, I think this should "just work" after removing the checks, as you did here. However, I also think it needs more testing. In particular, I think that we need randomized testing of primary key renaming in alter_table-randomized-test.cc, and I'd like to see coverage in alter_table-test.cc as well.

http://gerrit.cloudera.org:8080/#/c/6078/3//COMMIT_MSG
Commit Message:

PS3, Line 9: primary key column name
           : to be renamed
nit: renaming of primary key columns


http://gerrit.cloudera.org:8080/#/c/6078/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java:

PS3, Line 35: import static org.junit.Assert.*;
We loosely adhere to Google's Java style guide, which disallows wildcard imports (https://google.github.io/styleguide/javaguide.html#s3.3-import-statements).


PS3, Line 161: // Add a row
Can you add a row before the alter as well? An alter should trigger a flush, which is something I'd want to see tested with a non-empty table whose primary key is being renamed.


PS3, Line 171: }
Can you check the results of a scan are correct? Try using a projection on the renamed key column.


-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6078

to look at the new patch set (#12).

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................

KUDU-1890 Allow renaming of primary key column

Removed the checks preventing renaming of primary key
columns, added test cases and updated documents.

Testing: Ran a loop of 100 alter_table-randomized-test.cc test
successfully which includes modification to rename a primary key
and non-primary columns.

Addressed code review comments

Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
---
M docs/developing.adoc
M docs/known_issues.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/client-test.cc
M src/kudu/client/table_alterer-internal.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet.cc
13 files changed, 222 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/6078/12
-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 5:

> (1 comment)
 > 
 > Pretty much LGTM. One small docs nit, and it looks like a
 > security-related changelist got mixed in with this one. Can you try
 > to extricate just your changes? I bet it'd be fine to push as is if
 > the unrelated changes are from a commit but I'd rather not do that.
 >  Also, could you loop the randomized test a few hundred times just
 > to check there's no failures, and note that you did so in the
 > commit message?

Not sure what I was on about with the security thing. I must've hit some wrong button or followed a link or something.

-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 13: Code-Review+2 Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Ram Mettu has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 4:

(4 comments)

Added test cases from alter_table-test.cc and alter_table-randomized-test.cc as suggested.

http://gerrit.cloudera.org:8080/#/c/6078/3//COMMIT_MSG
Commit Message:

PS3, Line 9: renaming of primary key
           : columns, adde
> nit: renaming of primary key columns
Done


http://gerrit.cloudera.org:8080/#/c/6078/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java:

PS3, Line 35: 
> We loosely adhere to Google's Java style guide, which disallows wildcard im
reverted back to the original


PS3, Line 161: 
> Can you add a row before the alter as well? An alter should trigger a flush
Done


PS3, Line 171:  
> Can you check the results of a scan are correct? Try using a projection on 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 7:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/6078/7/docs/known_issues.adoc
File docs/known_issues.adoc:

PS7, Line 36: * Columns that are part of the primary key can be renamed.
I don't think we need this sentence at all given this is a "limitations" section.


http://gerrit.cloudera.org:8080/#/c/6078/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java:

Line 162:     // Reopen table for the new schema.
can you add some assertion of what happens if you try scanning with the old schema? make sure the exception is reasonable?


http://gerrit.cloudera.org:8080/#/c/6078/7/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

PS7, Line 3233: that changes dataType of primary column
nit: "Test that changing the data type of a primary key column throws an error"


PS7, Line 3240: Not implemented: cannot support AlterColumn of this type: key2
this isn't a great error message. Can we improve it to be more clear, like "cannot alter columns that are part of the primary key"?


http://gerrit.cloudera.org:8080/#/c/6078/7/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:

Line 927
see below


PS7, Line 947: 
             : 
I think we should still have some dcheck that the IDs and types match, even if the names may have changed.


-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6078

to look at the new patch set (#7).

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................

KUDU-1890 Allow renaming of primary key column

Removed the checks preventing renaming of primary key
columns, added test cases and updated documents.

Testing: Ran a loop of 100 alter_table-randomized-test.cc test
successfully which includes modification to rename a primary key
and non-primary columns.

Addressed code review comments

Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
---
M docs/developing.adoc
M docs/known_issues.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet.cc
10 files changed, 130 insertions(+), 39 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/6078/7
-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6078

to look at the new patch set (#8).

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................

KUDU-1890 Allow renaming of primary key column

Removed the checks preventing renaming of primary key
columns, added test cases and updated documents.

Testing: Ran a loop of 100 alter_table-randomized-test.cc test
successfully which includes modification to rename a primary key
and non-primary columns.

Addressed code review comments

Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
---
M docs/developing.adoc
M docs/known_issues.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/client-test.cc
M src/kudu/client/table_alterer-internal.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet.cc
13 files changed, 182 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/6078/8
-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6078

to look at the new patch set (#9).

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................

KUDU-1890 Allow renaming of primary key column

Removed the checks preventing renaming of primary key
columns, added test cases and updated documents.

Testing: Ran a loop of 100 alter_table-randomized-test.cc test
successfully which includes modification to rename a primary key
and non-primary columns.

Addressed code review comments

Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
---
M docs/developing.adoc
M docs/known_issues.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/client-test.cc
M src/kudu/client/table_alterer-internal.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet.cc
13 files changed, 218 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/6078/9
-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Ram Mettu has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 7:

(3 comments)

Yes, Jenkins test failures are unrelated.

http://gerrit.cloudera.org:8080/#/c/6078/5/docs/known_issues.adoc
File docs/known_issues.adoc:

Line 37:   The primary key may not be changed after the table is created.
> Mention that the primary key can be renamed, since "the primary key may not
Done


http://gerrit.cloudera.org:8080/#/c/6078/6/docs/known_issues.adoc
File docs/known_issues.adoc:

PS6, Line 37: after the tab
> I don't think this helps. If you remove it, I think it will be fine, as it 
Done


http://gerrit.cloudera.org:8080/#/c/6078/6/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

PS6, Line 3224: test renaming primary key column
> nit: test renaming primary key column
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Ram Mettu has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 9:

(5 comments)

Addressed code review comments

http://gerrit.cloudera.org:8080/#/c/6078/8/src/kudu/common/schema-test.cc
File src/kudu/common/schema-test.cc:

Line 120: }
> can you add a test that verifies that the nullability has not changed? ie i
Cannot add nullability on the key column, it asserts when creating the Schema object


http://gerrit.cloudera.org:8080/#/c/6078/8/src/kudu/common/schema.h
File src/kudu/common/schema.h:

PS8, Line 214: ype_info()->type();
> instead of two bools, how about a bitset of flags? eg COMPARE_DEFAULTS | CO
Implemented with bitset parameter, please take a look at the latest changes


Line 217:   bool Equals(const ColumnSchema &other,
> warning: don't use else after return [readability-else-after-return]
Done


PS8, Line 215:   }
             : 
             :   bool Equals(const ColumnSchema &other,
             :  
> it seems like these conditions could be simplified a bit, right? you don't 
Done


PS8, Line 657:     return true;
             :   }
             : 
             :   // Return true if the key projection schemas have exactly the same set of
             :   // columns and
> this is mostly repeated code from the above KeyEquals. if using flags as su
Removed the duplicated code, but kept the KeyTypeEquals() so it is easy for callers not have to worry about ColumnSchema::COMPARE* flags


-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Ram Mettu has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6078/4/src/kudu/integration-tests/alter_table-randomized-test.cc
File src/kudu/integration-tests/alter_table-randomized-test.cc:

Line 459:     auto bounds = ts_.AddRangePartition();
> warning: non-const reference parameter 'schema', make it const or use a poi
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6078

to look at the new patch set (#10).

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................

KUDU-1890 Allow renaming of primary key column

Removed the checks preventing renaming of primary key
columns, added test cases and updated documents.

Testing: Ran a loop of 100 alter_table-randomized-test.cc test
successfully which includes modification to rename a primary key
and non-primary columns.

Addressed code review comments

Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
---
M docs/developing.adoc
M docs/known_issues.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/client-test.cc
M src/kudu/client/table_alterer-internal.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet.cc
13 files changed, 217 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/6078/10
-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 5:

(1 comment)

Pretty much LGTM. One small docs nit, and it looks like a security-related changelist got mixed in with this one. Can you try to extricate just your changes? I bet it'd be fine to push as is if the unrelated changes are from a commit but I'd rather not do that.  Also, could you loop the randomized test a few hundred times just to check there's no failures, and note that you did so in the commit message?

http://gerrit.cloudera.org:8080/#/c/6078/5/docs/known_issues.adoc
File docs/known_issues.adoc:

Line 37:   You must drop and recreate a table to select a new primary key.
Mention that the primary key can be renamed, since "the primary key may not be changed" will imply it cannot be renamed to many people.


-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 8:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/6078/8/src/kudu/common/schema-test.cc
File src/kudu/common/schema-test.cc:

Line 120: }
can you add a test that verifies that the nullability has not changed? ie if one column is STRING NOT NULL and the other is STRING (nullable), then it should not be KeyTypeEqual


http://gerrit.cloudera.org:8080/#/c/6078/8/src/kudu/common/schema.h
File src/kudu/common/schema.h:

PS8, Line 214: bool check_defaults, bool check_na
instead of two bools, how about a bitset of flags? eg COMPARE_DEFAULTS | COMPARE_NAMES


PS8, Line 215:     if (check_name && (!EqualsType(other) || this->name_ != other.name_))
             :       return false;
             :     else if (!EqualsType(other))
             :  
it seems like these conditions could be simplified a bit, right? you don't need the EqualsType part in the top condition anymore. Also, I agree with tidybot


PS8, Line 657:     if (this->num_key_columns_ != other.num_key_columns_) return false;
             :     for (size_t i = 0; i < this->num_key_columns_; i++) {
             :       if (!this->cols_[i].Equals(other.cols_[i], false, false)) return false;
             :     }
             :     return true;
this is mostly repeated code from the above KeyEquals. if using flags as suggested then you can just implement this once and propagate the flags into the Equals method


-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 6:

(2 comments)

Two doc+comment fixes and LGTM. I think the test failures are unrelated timeouts.

http://gerrit.cloudera.org:8080/#/c/6078/6/docs/known_issues.adoc
File docs/known_issues.adoc:

PS6, Line 37: (col1 to col2
I don't think this helps. If you remove it, I think it will be fine, as it says first that keys can be renamed before saying they can't be changed.


http://gerrit.cloudera.org:8080/#/c/6078/6/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

PS6, Line 3224: test that renames primary key column name
nit: test renaming primary key column


-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Ram Mettu has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 8:

Test failures are unrelated

-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6078

to look at the new patch set (#4).

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................

KUDU-1890 Allow renaming of primary key column

Removed the checks preventing renaming of primary key
columns, added test cases and updated documents.

Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
---
M docs/developing.adoc
M docs/known_issues.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet.cc
10 files changed, 131 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/6078/4
-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6078

to look at the new patch set (#6).

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................

KUDU-1890 Allow renaming of primary key column

Removed the checks preventing renaming of primary key
columns, added test cases and updated documents.

Testing: Ran a loop of 100 alter_table-randomized-test.cc test
successfully which includes modification to rename a primary key
and non-primary columns.

Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
---
M docs/developing.adoc
M docs/known_issues.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet.cc
10 files changed, 131 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/6078/6
-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6078

to look at the new patch set (#3).

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................

KUDU-1890 Allow renaming of primary key column

Removed the checks preventing primary key column name
to be renamed, added test cases and updated documents.

Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
---
M docs/developing.adoc
M docs/known_issues.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/client-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet.cc
8 files changed, 57 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/6078/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Ram Mettu has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 13:

Addressed Todd's comments.

The jenkins testcase failure is unrelated to this change.

-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6078/11/src/kudu/common/schema.h
File src/kudu/common/schema.h:

PS11, Line 218: bitset<8> checks = UCHAR_MAX
hrm, we don't actually use std::bitset elsewhere for this style of flag, and instead use 'int' and a normal enum. Check out util/trace.h:164 for example.


PS11, Line 287: static const uint8_t COMPARE_NAME     = 0x01;
              :   static const uint8_t COMPARE_TYPE     = 0x02;
              :   static const uint8_t COMPARE_DEFAULTS = 0x04;
please switch to enum following the example in trace.h


-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6078

to look at the new patch set (#5).

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................

KUDU-1890 Allow renaming of primary key column

Removed the checks preventing renaming of primary key
columns, added test cases and updated documents.

Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
---
M docs/developing.adoc
M docs/known_issues.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet.cc
10 files changed, 130 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/6078/5
-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Ram Mettu has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 8:

(5 comments)

Addressed Todd's comments

http://gerrit.cloudera.org:8080/#/c/6078/7/docs/known_issues.adoc
File docs/known_issues.adoc:

PS7, Line 36: * The primary key may not be changed after the table is cr
> I don't think we need this sentence at all given this is a "limitations" se
Done


http://gerrit.cloudera.org:8080/#/c/6078/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java:

Line 162:     // scanning with the old schema
> can you add some assertion of what happens if you try scanning with the old
Done


http://gerrit.cloudera.org:8080/#/c/6078/7/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

PS7, Line 3233: that changing the data type of a primar
> nit: "Test that changing the data type of a primary key column throws an er
Done


PS7, Line 3240: Not implemented: cannot alter attributes for column: key2");
> this isn't a great error message. Can we improve it to be more clear, like 
Changed the error msg a little but not specific as suggested, the code throwing this error does a lot of checks (eg primary key, compression, encoding etc), hope that is okay


http://gerrit.cloudera.org:8080/#/c/6078/7/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:

PS7, Line 947: 
             : 
> I think we should still have some dcheck that the IDs and types match, even
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6078

to look at the new patch set (#2).

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................

KUDU-1890 Allow renaming of primary key column

Removed the checks preventing primary key column name
to be renamed, added test cases and updated documents.

Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/client-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet.cc
4 files changed, 50 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/6078/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6078

to look at the new patch set (#13).

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................

KUDU-1890 Allow renaming of primary key column

Removed the checks preventing renaming of primary key
columns, added test cases and updated documents.

Testing: Ran a loop of 100 alter_table-randomized-test.cc test
successfully which includes modification to rename a primary key
and non-primary columns.

Addressed code review comments

Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
---
M docs/developing.adoc
M docs/known_issues.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/client-test.cc
M src/kudu/client/table_alterer-internal.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tablet/tablet.cc
13 files changed, 219 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/6078/13
-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Posted by "Ram Mettu (Code Review)" <ge...@cloudera.org>.
Ram Mettu has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 11:

Merged with latest master branch

-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ra...@rms.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No