You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "FlorianHockmann (GitHub)" <gi...@apache.org> on 2018/12/26 17:02:11 UTC
[GitHub] [tinkerpop] FlorianHockmann opened pull request #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
https://issues.apache.org/jira/browse/TINKERPOP-2088
This requires contributors to update to .NET Core SDK 2.1.300 or newer.
Travis and the Docker build now use the most recent SDK 2.2.
SourceLink should make it easier for users to debug Gremlin.Net within their application as they get better access to the source code of Gremlin.Net during debugging. That is why the .NET open-source library guidance recommends to enable it for libraries.
The generated NuGet package includes a reference to our git repository as well as the commit that belongs to the version included in the package:
I verified that the Docker build still works with `docker/build.sh`.
VOTE +1
NOTE: We don't need to merge this for the upcoming release, especially since we have have a code freeze (although we don't strictly follow that for GLVs). I just had some spare time to work on this, but we can also merge it after the 3.3.5 release.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] dkuppitz commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
See: https://gist.github.com/dkuppitz/1b912747180b07ab08d4eb98175c119b
I'm really wondering how you're able to get a clean build using the same docker images, so confusing...
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "spmallette (GitHub)" <gi...@apache.org>.
wonder if that's related to nuget....we still have some odd build problems around clean repos that don't have nuget present i think. i have that on my list of things to review.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] dkuppitz commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
It finally worked! I'll add `git -fxd` in our Docker build script.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
```
[echo] docfx already downloaded.
[exec] [19-01-23 03:56:27.186]Info:Config file docfx.json found, start generating metadata...
[...]
[exec] [19-01-23 03:56:35.566]Error:System.AggregateException: One or more errors occurred. (/projects/apache/tinkerpop/gremlin-dotnet/src/obj/.cache/build/ysbgevf3.uyr/4heij3cn.9cl does not exist) (/projects/apache/tinkerpop/gremlin-dotnet/src/obj/.cache/build/ysbgevf3.uyr/daniuqee.e1y does not exist) (/projects/apache/tinkerpop/gremlin-dotnet/src/obj/.cache/build/ysbgevf3.uyr/0impaqz3.kb3 does not exist) (/projects/apache/tinkerpop/gremlin-dotnet/src/obj/.cache/build/ysbgevf3.uyr/iqzrlx55.yny does not exist) (/projects/apache/tinkerpop/gremlin-dotnet/src/obj/.cache/build/ysbgevf3.uyr/vs6atryj.pzx does not exist) (/projects/apache/tinkerpop/gremlin-dotnet/src/obj/.cache/build/ysbgevf3.uyr/d3rvlip0.vup does not exist) (/projects/apache/tinkerpop/gremlin-dotnet/src/obj/.cache/build/ysbgevf3.uyr/x8o77bsj.6qp does not exist) (/projects/apache/tinkerpop/gremlin-dotnet/src/obj/.cache/build/ysbgevf3.uyr/hqh7xcur.kbb does not exist) ---> System.IO.FileNotFoundException: /projects/apache/tin
kerpop/gremlin-dotnet/src/obj/.cache/build/ysbgevf3.uyr/4heij3cn.9cl does not exist
```
That seems to be a problem with DocFX generating the API docs. Can you try it with a cleanly checked out repo (especially without the files generated by DocFX)?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
Do you get an exception?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "spmallette (GitHub)" <gi...@apache.org>.
> We don't need to merge this for the upcoming release,
agreed - let's save this so that we don't do anything to throw a wrench into release at this point given those environment changes that are required here.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] dkuppitz commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
Yep, nice, that solved it!
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann closed pull request #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
[ pull request closed by FlorianHockmann ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] dkuppitz commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
It finally worked! I'll add `git -fxd` in our Docker build script.
EDIT: Dah, no, I won't do that. I tend to run `docker/build.sh -t -i` before I commit my changes (including new files and directories). Thus, this cleanup should be something we should just keep in mind; I don't think we'll need it too often.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] dkuppitz commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
Well, the images build fine now, but `gremlin-dotnet-source` doesn't.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
```
has premature member 'control.tar.xz' before 'control.tar.gz', giving up
```
Wait, I got exactly the same error in this PR with Travis and added this line to the `.travis.yml` which fixed it there:
```
- sudo apt-get install -y dpkg # workaround for travis-ci/travis-ci#9361
```
and as the comment indicates, this problem is described here: travis-ci/travis-ci#9361 (where I also got this workaround).
Can you try whether it also fixes the problem with the Docker build if you add that line to the Dockerfile?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
Do you get an exception?
edit: I created [TINKERPOP-2140](https://issues.apache.org/jira/browse/TINKERPOP-2140) to add the Docker build to our Travis build.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] dkuppitz commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
The Docker builds seem to be broken now. After deleting the existing docker images, I get the following error when `docker.build.sh` tries to rebuild the images:
```
...
Updating certificates in /etc/ssl/certs... 0 added, 0 removed; done.
Running hooks in /etc/ca-certificates/update.d....done.
Processing triggers for ureadahead (0.100.0-16) ...
Errors were encountered while processing:
/var/cache/apt/archives/aspnetcore-runtime-2.2_2.2.1-1_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)
The command '/bin/sh -c apt-get update && apt-get -y install software-properties-common python-software-properties apt-transport-https curl && echo oracle-java8-installer shared/accepted-oracle-license-v1-1 select true | debconf-set-selections && add-apt-repository -y ppa:webupd8team/java && sh -c 'curl -s https://packages.microsoft.com/config/ubuntu/14.04/packages-microsoft-prod.deb -o packages-microsoft-prod.deb' && sh -c 'dpkg -i packages-microsoft-prod.deb' && sh -c 'echo "deb https://download.mono-project.com/repo/ubuntu stable-trusty main" | sudo tee /etc/apt/sources.list.d/mono-official-stable.list' && apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 3FA7E0328081BFF6A14DA29AA6A19B38D3D831EF && apt-get update && apt-get install -y oracle-java8-installer gawk git maven openssh-server subversion zip && apt-get install -y --force-yes dotnet-sdk-2.2 python python-dev python3-dev python-pip build-essential mono-devel && pi
p install virtualenv virtualenvwrapper && pip install --upgrade pip && rm -rf /var/lib/apt/lists/* /var/cache/oracle-jdk8-installer' returned a non-zero code: 100
```
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] dkuppitz commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
So weird. Failed for me 3 times in a row now. Also, I found this message a bit higher in the log:
```
Selecting previously unselected package dotnet-runtime-2.2.
Preparing to unpack .../dotnet-runtime-2.2_2.2.1-1_amd64.deb ...
Unpacking dotnet-runtime-2.2 (2.2.1-1) ...
dpkg-deb: error: archive '/var/cache/apt/archives/aspnetcore-runtime-2.2_2.2.1-1_amd64.deb' has premature member 'control.tar.xz' before 'control.tar.gz', giving up
dpkg: error processing archive /var/cache/apt/archives/aspnetcore-runtime-2.2_2.2.1-1_amd64.deb (--unpack):
subprocess dpkg-deb --control returned error exit status 2
```
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1026:
TINKERPOP-2088 Enable SourceLink for Gremlin.Net
Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
That's strange. It still works fine for me. I used this to delete any existing images and then start the build:
```bash
docker system prune -af
docker/build.sh
```
We could in general add another Travis job to run `docker/build.sh` to ensure that we don't accidentally break the Docker build. I remember that we had issues like this already a few times now, although I'm of course not sure whether this approach would have found every problem in the Docker build.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org