You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2009/02/26 20:55:04 UTC
[jira] Created: (HADOOP-5341) hadoop-daemon isn't compatible after
HADOOP-4868
hadoop-daemon isn't compatible after HADOOP-4868
------------------------------------------------
Key: HADOOP-5341
URL: https://issues.apache.org/jira/browse/HADOOP-5341
Project: Hadoop Core
Issue Type: Bug
Components: scripts
Reporter: Owen O'Malley
Assignee: Sharad Agarwal
Priority: Blocker
Fix For: 0.20.0
The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5341) hadoop-daemon isn't compatible
after HADOOP-4868
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681803#action_12681803 ]
Hudson commented on HADOOP-5341:
--------------------------------
Integrated in Hadoop-trunk #778 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/778/])
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Fix For: 0.21.0
>
> Attachments: 5341_v1.patch, 5341_v2.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5341) hadoop-daemon isn't compatible
after HADOOP-4868
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677910#action_12677910 ]
Sharad Agarwal commented on HADOOP-5341:
----------------------------------------
incorporated jothi's comment v2.
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 5341_v1.patch, 5341_v2.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5341) hadoop-daemon isn't compatible after
HADOOP-4868
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-5341:
-----------------------------------
Status: Patch Available (was: Open)
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 5341_v1.patch, 5341_v2.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5341) hadoop-daemon isn't compatible
after HADOOP-4868
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678253#action_12678253 ]
Hadoop QA commented on HADOOP-5341:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401220/5341_v2.patch
against trunk revision 749318.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/36/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/36/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/36/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/36/console
This message is automatically generated.
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 5341_v1.patch, 5341_v2.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5341) hadoop-daemon isn't compatible
after HADOOP-4868
Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677932#action_12677932 ]
Jothi Padmanabhan commented on HADOOP-5341:
-------------------------------------------
+1
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 5341_v1.patch, 5341_v2.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5341) hadoop-daemon isn't compatible
after HADOOP-4868
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679198#action_12679198 ]
Hemanth Yamijala commented on HADOOP-5341:
------------------------------------------
Sharad, this patch is not applying to the 0.20 branch. Can you please upload a separate patch for the same ?
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 5341_v1.patch, 5341_v2.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5341) hadoop-daemon isn't compatible
after HADOOP-4868
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679071#action_12679071 ]
Owen O'Malley commented on HADOOP-5341:
---------------------------------------
+1
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 5341_v1.patch, 5341_v2.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5341) hadoop-daemon isn't compatible after
HADOOP-4868
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-5341:
-----------------------------------
Attachment: 5341_v2.patch
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 5341_v1.patch, 5341_v2.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5341) hadoop-daemon isn't compatible
after HADOOP-4868
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678608#action_12678608 ]
Sharad Agarwal commented on HADOOP-5341:
----------------------------------------
test failures are unrelated
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 5341_v1.patch, 5341_v2.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5341) hadoop-daemon isn't compatible after
HADOOP-4868
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-5341:
-----------------------------------
Attachment: 5341_v1.patch
made the sub system script argument as optional. the default value is bin/hadoop
also fixed the bin/hadoop script. using exec to launch bin/mapred and bin/hdfs
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 5341_v1.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5341) hadoop-daemon isn't compatible after
HADOOP-4868
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-5341:
-----------------------------------
Priority: Major (was: Blocker)
Fix Version/s: (was: 0.20.0)
0.21.0
This issue should be for 0.21 as the original issue (HADOOP-4868) which introduced it, was committed for 0.21.
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Fix For: 0.21.0
>
> Attachments: 5341_v1.patch, 5341_v2.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5341) hadoop-daemon isn't compatible
after HADOOP-4868
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677935#action_12677935 ]
Sharad Agarwal commented on HADOOP-5341:
----------------------------------------
all core tests passed. Also did manual testing by starting and stopping the cluster on my local machine.
test-patch output is:
-1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 5341_v1.patch, 5341_v2.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5341) hadoop-daemon isn't compatible
after HADOOP-4868
Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677904#action_12677904 ]
Jothi Padmanabhan commented on HADOOP-5341:
-------------------------------------------
Looks good. One minor nit. I think the check "if [ $# -gt 1 ]" can be removed as the start/stop argument is anyhow expected at that point.
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 5341_v1.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5341) hadoop-daemon isn't compatible after
HADOOP-4868
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-5341:
-------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Sharad !
> hadoop-daemon isn't compatible after HADOOP-4868
> ------------------------------------------------
>
> Key: HADOOP-5341
> URL: https://issues.apache.org/jira/browse/HADOOP-5341
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Owen O'Malley
> Assignee: Sharad Agarwal
> Fix For: 0.21.0
>
> Attachments: 5341_v1.patch, 5341_v2.patch
>
>
> The CLI changed for hadoop-daemon.sh in an incompatible way. It now requires the sub-system name in the CLI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.