[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1581: MINIFICPP-2125 fix for waking up prematurely after processor yields

["martinzink (via GitHub)" <gi...@apache.org>]

martinzink commented on code in PR #1581:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1581#discussion_r1213029823


##########
libminifi/test/unit/ThreadPoolTests.cpp:
##########
@@ -84,7 +81,33 @@ TEST_CASE("ThreadPoolTest2", "[TPT2]") {
   utils::Worker<int> functor(f_ex, "id", std::move(after_execute));
   pool.start();
   std::future<int> fut;
-  pool.execute(std::move(functor), fut);  // NOLINT(bugprone-use-after-move)
+  pool.execute(std::move(functor), fut);
   fut.wait();
   REQUIRE(20 == fut.get());
 }
+
+TEST_CASE("Worker wait time should be relative to the last run") {
+  std::mutex cv_m;
+  std::condition_variable cv;

Review Comment:
   I've simplified this test in https://github.com/apache/nifi-minifi-cpp/pull/1581/commits/187f07eb04efef01712e81cd9f3fc1dfa93bc93d



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org