You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/21 08:35:04 UTC
[GitHub] [incubator-nuttx] ramangopalan opened a new pull request #3761: ET-STM32 Stamp: An STM32F103RET6 target for NuttX
ramangopalan opened a new pull request #3761:
URL: https://github.com/apache/incubator-nuttx/pull/3761
Dear list, greetings!
## Summary
This PR brings NuttX to the ET-STM32 Stamp module [1] from Futurlec. I
also utilized this opportunity to get familiar with the NuttX
internals and parts of the ARM codebase. Many thanks for NuttX!
I went through the list of already supported STM32F103 platforms. I
picked Maple as a starting point. I made an et-stm32-stamp directory
and added an initial NSH configuration. I touched boards/Kconfig for
menuconfig.
The Stamp is a very compact PCB with just pinouts. It doesn't have any
on-board peripherals; Not even a GPIO_LED OR a button I can detect
with an interrupt.
The nsh configuration is very minimal for now. It doesn't initialize/utilize
any other MCU peripheral of the on-board STM32F103RET6. I will slowly
start adding newer configurations by reading stm32f103-mimimum/.
## Impact
This PR doesn't conflict with any other board/sub-system. It is
independent.
## Testing
1) I have tested et-stm32-stamp/nsh using WSL with my Stamp
module. I have documented the details in the board README file. Can
you please let me know if the code is OK and if there's anything
else I can do in this regard?
2) This PR should pass the CI tests.
Many thanks.
References:
[1]: https://www.futurlec.com/ET-STM32_Stamp.shtml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ramangopalan commented on pull request #3761: ET-STM32 Stamp: An STM32F103RET6 target for NuttX
Posted by GitBox <gi...@apache.org>.
ramangopalan commented on pull request #3761:
URL: https://github.com/apache/incubator-nuttx/pull/3761#issuecomment-845867124
Many thanks for the suggestions David!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3761: ET-STM32 Stamp: An STM32F103RET6 target for NuttX
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #3761:
URL: https://github.com/apache/incubator-nuttx/pull/3761#discussion_r636746722
##########
File path: boards/arm/stm32/et-stm32-stamp/include/board.h
##########
@@ -0,0 +1,167 @@
+/****************************************************************************
+ * boards/arm/stm32/et-stm32-stamp/include/board.h
+ * include/arch/board/board.h
Review comment:
This is useful when learning NuttX. I like it, but not to the coding standard.
##########
File path: boards/arm/stm32/et-stm32-stamp/include/board.h
##########
@@ -0,0 +1,167 @@
+/****************************************************************************
Review comment:
New submission should use the Apache licence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #3761: ET-STM32 Stamp: An STM32F103RET6 target for NuttX
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #3761:
URL: https://github.com/apache/incubator-nuttx/pull/3761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org