[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4586: Adding Predicate supports for Bytes Column without dictionary

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4586: Adding Predicate supports for Bytes Column without dictionary
URL: https://github.com/apache/incubator-pinot/pull/4586#discussion_r321437584
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/InPredicateEvaluatorFactory.java
 ##########
 @@ -233,4 +236,24 @@ public boolean applySV(String value) {
       return _matchingValues.contains(value);
     }
   }
+
+  private static final class BytesRawValueBasedInPredicateEvaluator extends BaseRawValueBasedPredicateEvaluator {
+    final Set<String> _matchingValues;
 
 Review comment:
   Storing `Set<ByteArray>` should be faster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org