You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/04 00:39:42 UTC
[GitHub] [helix] kaisun2000 commented on a change in pull request #1328: Implement TestBestPossibleExternalViewVerifier
kaisun2000 commented on a change in pull request #1328:
URL: https://github.com/apache/helix/pull/1328#discussion_r483324078
##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/TestBestPossibleExternalViewVerifier.java
##########
@@ -0,0 +1,133 @@
+package org.apache.helix.tools.ClusterVerifiers;
+
+import java.util.Map;
+import java.util.Set;
+
+import org.apache.helix.zookeeper.api.client.RealmAwareZkClient;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+public class TestBestPossibleExternalViewVerifier extends BestPossibleExternalViewVerifier {
+ private static Logger LOG = LoggerFactory.getLogger(TestBestPossibleExternalViewVerifier.class);
+ private static int COOL_DOWN = 2 * 1000;
+
+ private TestBestPossibleExternalViewVerifier(RealmAwareZkClient zkClient, String clusterName,
+ Map<String, Map<String, String>> errStates, Set<String> resources,
+ Set<String> expectLiveInstances) {
+ super (zkClient, clusterName, errStates, resources, expectLiveInstances);
+ }
+ /**
+ * Deprecated - please use the Builder to construct this class.
+ * @param zkAddr
+ * @param clusterName
+ * @param resources
+ * @param errStates
+ * @param expectLiveInstances
+ */
+ @Deprecated
+ public TestBestPossibleExternalViewVerifier(String zkAddr, String clusterName, Set<String> resources,
+ Map<String, Map<String, String>> errStates, Set<String> expectLiveInstances) {
+ super(zkAddr, clusterName, resources, errStates, expectLiveInstances);
+ }
+
+ /**
+ * Deprecated - please use the Builder to construct this class.
+ * @param zkClient
+ * @param clusterName
+ * @param resources
+ * @param errStates
+ * @param expectLiveInstances
+ */
+ @Deprecated
+ public TestBestPossibleExternalViewVerifier(RealmAwareZkClient zkClient, String clusterName,
+ Set<String> resources, Map<String, Map<String, String>> errStates,
+ Set<String> expectLiveInstances) {
+ super(zkClient, clusterName, resources, errStates, expectLiveInstances);
+ }
+
+ public static class Builder extends ZkHelixClusterVerifier.Builder<TestBestPossibleExternalViewVerifier.Builder> {
Review comment:
Good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org