You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/01/20 04:43:00 UTC
[GitHub] [echarts] pissang commented on a change in pull request #16395: fix(core): avoid error in render breaks following update
pissang commented on a change in pull request #16395:
URL: https://github.com/apache/echarts/pull/16395#discussion_r788345998
##########
File path: src/core/echarts.ts
##########
@@ -1196,9 +1212,13 @@ class ECharts extends Eventful<ECEventDefinition> {
* Resize the chart
*/
resize(opts?: ResizeOpts): void {
- if (__DEV__) {
- assert(!this[IN_MAIN_PROCESS_KEY], '`resize` should not be called during main process.');
+ if (this[IN_MAIN_PROCESS_KEY]) {
+ if (__DEV__) {
+ error('`setOption` should not be called during main process.');
Review comment:
Thanks! Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org