You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2016/09/01 19:44:57 UTC

[Impala-CR] IMPALA-4004: Don't access nested types in test failpoints.py 

Hello Internal Jenkins, Alex Behm,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4253

to review the following change.

Change subject: IMPALA-4004: Don't access nested types in test_failpoints.py
......................................................................

IMPALA-4004: Don't access nested types in test_failpoints.py

As part of fixing IMPALA-3692, the query in test_failpoints.py was
updated to have a predicate on a string column in a parquet table.
The update to the query was based on the failing query in the bug
which happens to access nested columns. Apparently, this doesn't
quite work with the legacy join and agg.

This change fixes the test to also work with legacy join and agg.
With the debug actions added in the fix of IMPALA-3692, it's not
necessary to access nested types to reproduce the problem as long
as there is a predicate on a string column.

Change-Id: Idc5e67b9748a13fcd76ea5fe140e2e6b18e809b7
Reviewed-on: http://gerrit.cloudera.org:8080/4074
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit b251fb0615d2bcdaade93a5d939c7ab6bc64960c)
---
M tests/failure/test_failpoints.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/53/4253/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc5e67b9748a13fcd76ea5fe140e2e6b18e809b7
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>

[Impala-CR] IMPALA-4004: Don't access nested types in test failpoints.py

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change.

Change subject: IMPALA-4004: Don't access nested types in test_failpoints.py
......................................................................


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/4253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Idc5e67b9748a13fcd76ea5fe140e2e6b18e809b7
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>