You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Mark Miller <ma...@gmail.com> on 2014/02/16 21:45:38 UTC

Re: svn commit: r1568824 - /lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java

Thanks!

- Mark

http://about.me/markrmiller

On Feb 16, 2014, at 3:37 PM, shaie@apache.org wrote:

> Author: shaie
> Date: Sun Feb 16 20:37:28 2014
> New Revision: 1568824
> 
> URL: http://svn.apache.org/r1568824
> Log:
> LUCENE-5440: fix bug in FacetComponent
> 
> Modified:
>    lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java
> 
> Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java
> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java?rev=1568824&r1=1568823&r2=1568824&view=diff
> ==============================================================================
> --- lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java (original)
> +++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java Sun Feb 16 20:37:28 2014
> @@ -451,7 +451,7 @@ public class FacetComponent extends Sear
>           long maxCount = sfc.count;
>           for (int shardNum=0; shardNum<rb.shards.length; shardNum++) {
>             FixedBitSet fbs = dff.counted[shardNum];
> -            if (fbs!=null && !fbs.get(sfc.termNum)) {  // fbs can be null if a shard request failed
> +            if (fbs!=null && (sfc.termNum >= fbs.length() || !fbs.get(sfc.termNum))) {  // fbs can be null if a shard request failed
>               // if missing from this shard, add the max it could be
>               maxCount += dff.maxPossible(sfc,shardNum);
>             }
> @@ -466,7 +466,7 @@ public class FacetComponent extends Sear
>           // add a query for each shard missing the term that needs refinement
>           for (int shardNum=0; shardNum<rb.shards.length; shardNum++) {
>             FixedBitSet fbs = dff.counted[shardNum];
> -            if(fbs!=null && !fbs.get(sfc.termNum) && dff.maxPossible(sfc,shardNum)>0) {
> +            if(fbs!=null && (sfc.termNum >= fbs.length() || !fbs.get(sfc.termNum)) && dff.maxPossible(sfc,shardNum)>0) {
>               dff.needRefinements = true;
>               List<String> lst = dff._toRefine[shardNum];
>               if (lst == null) {
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org