You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "briancullen (via GitHub)" <gi...@apache.org> on 2023/10/22 09:41:52 UTC

[PR] AVRO-3889: [Java][Build] Maven IDL Generation Modification Check [avro]

briancullen opened a new pull request, #2561:
URL: https://github.com/apache/avro/pull/2561

   ## What is the purpose of the change
   
   This change adds an up to date check to the maven plugin when generating Java classes from avro IDL. The reason for the change is to prevent unnecessary recompilation of the java source code in projects using the plugin. 
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   - Added tests to verify that only missing files are regenerated when processing the avro IDL files.
   - Altered existing tests to ensure that files are generated and not used from previous test runs.
   
   Not sure if there are other scenarios that may be affected by this change.
   
   ## Documentation
   
   This pull request does not introduce a new feature and is not documented.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3889: [Java][Build] Maven IDL Generation Modification Check [avro]

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2561:
URL: https://github.com/apache/avro/pull/2561#issuecomment-1874984031

   Hi @briancullen !
   
   I maintain the Rust SDK.
   But I see that @opwvhk (a Java developer!) already approved this PR, so I can merge it for you!
   
   About the release: you can follow this discussion at dev@avro.apache.org - https://lists.apache.org/thread/sfmpn6dmrfpv4169tqx4klbw2dyqmz3z


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3889: [Java][Build] Maven IDL Generation Modification Check [avro]

Posted by "briancullen (via GitHub)" <gi...@apache.org>.
briancullen commented on PR #2561:
URL: https://github.com/apache/avro/pull/2561#issuecomment-1775894506

   @martin-g thanks for the feedback. Not sure if you wanted it but I created a similar pull request for the main branch and linked it to this (see #2564). Feel free to merge if you feel it is useful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3889: [Java][Build] Maven IDL Generation Modification Check [avro]

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #2561:
URL: https://github.com/apache/avro/pull/2561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3889: [Java][Build] Maven IDL Generation Modification Check [avro]

Posted by "briancullen (via GitHub)" <gi...@apache.org>.
briancullen commented on PR #2561:
URL: https://github.com/apache/avro/pull/2561#issuecomment-1774988362

   @opwvhk forgive the question but I’m not sure what the process for this project is. Is it ok for me to merge now and should I make the equivalent PR for master?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3889: [Java][Build] Maven IDL Generation Modification Check [avro]

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2561:
URL: https://github.com/apache/avro/pull/2561#issuecomment-1775781248

   No worries! The PR will be merged soon! Definitely before the next release!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3889: [Java][Build] Maven IDL Generation Modification Check [avro]

Posted by "briancullen (via GitHub)" <gi...@apache.org>.
briancullen commented on PR #2561:
URL: https://github.com/apache/avro/pull/2561#issuecomment-1775448972

   @martin-g actually no, now that you mention it, I can't see a merge button. Presumably as I don't have write access to the repository. I should have probably looked before I asked, sorry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3889: [Java][Build] Maven IDL Generation Modification Check [avro]

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2561:
URL: https://github.com/apache/avro/pull/2561#issuecomment-1775029784

   @briancullen Do you see the `Merge` button ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3889: [Java][Build] Maven IDL Generation Modification Check [avro]

Posted by "briancullen (via GitHub)" <gi...@apache.org>.
briancullen commented on PR #2561:
URL: https://github.com/apache/avro/pull/2561#issuecomment-1874953149

   @martin-g Just to follow up on this. Can this pull request, and possibly #2564, be merged? Also, out of curiosity, is there any timeline for when there might be another release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org