You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/30 03:47:12 UTC

[GitHub] [incubator-seatunnel] ic4y commented on a diff in pull request #2559: [Engine][Task] Use TaskGroupLocation instead of TaskGroupID

ic4y commented on code in PR #2559:
URL: https://github.com/apache/incubator-seatunnel/pull/2559#discussion_r957977242


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/operation/sink/SinkRegisterOperation.java:
##########
@@ -56,7 +56,7 @@ public void run() throws Exception {
         SinkAggregatedCommitterTask<?> task = null;
         for (int i = 0; i < RETRY_TIME; i++) {
             try {
-                task = server.getTaskExecutionService().getExecutionContext(committerTaskID.getTaskGroupID())

Review Comment:
   Our current TaskID is not unique and may be repeated in different jobs or pipelines



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org