You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/12/08 18:44:04 UTC

[GitHub] zheng-da commented on a change in pull request #8302: Refactor operators & MKLDNN

zheng-da commented on a change in pull request #8302: Refactor operators & MKLDNN
URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r155845973
 
 

 ##########
 File path: Makefile
 ##########
 @@ -40,11 +40,11 @@ endif
 # use customized config file
 include $(config)
 
-ifeq ($(USE_MKL2017), 1)
-# must run ./prepare_mkl before including mshadow.mk
-	RETURN_STRING := $(shell ./prepare_mkl.sh $(MKLML_ROOT))
-	MKLROOT := $(firstword $(RETURN_STRING))
-	export USE_MKLML = $(lastword $(RETURN_STRING))
+ifeq ($(USE_MKLDNN), 1)
 
 Review comment:
   Not yet. I'll update.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services