You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "haifxu (via GitHub)" <gi...@apache.org> on 2023/06/26 02:43:27 UTC

[GitHub] [inlong] haifxu opened a new pull request, #8317: [INLONG-8316][Dashboard] Update length limit for partial ID or name field

haifxu opened a new pull request, #8317:
URL: https://github.com/apache/inlong/pull/8317

   ### Prepare a Pull Request
   
   - Fixes #8316 
   
   ### Motivation
   
   Consistent with the Manager: https://github.com/apache/inlong/pull/8283
   
   ### Modifications
   
   1. Update length limit for partial ID or name field
   2. Modify some validation rules
   
   ### Verifying this change
   
   - [ ] This change is a trivial rework/code cleanup without any test coverage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] haifxu commented on a diff in pull request #8317: [INLONG-8316][Dashboard] Update length limit for partial ID or name field

Posted by "haifxu (via GitHub)" <gi...@apache.org>.
haifxu commented on code in PR #8317:
URL: https://github.com/apache/inlong/pull/8317#discussion_r1241736502


##########
inlong-dashboard/src/plugins/groups/common/GroupDefaultInfo.ts:
##########
@@ -39,12 +39,12 @@ export class GroupDefaultInfo implements DataWithBackend, RenderRow, RenderList
   @FieldDecorator({
     type: 'input',
     props: {
-      maxLength: 100,
+      maxLength: 200,
     },
     rules: [
       { required: true },
       {
-        pattern: /^[a-z_0-9]+$/,
+        pattern: /^[a-zA-Z0-9_.-]+$/,
         message: i18n.t('meta.Group.InlongGroupIdRules'),

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #8317: [INLONG-8316][Dashboard] Update length limit for partial ID or name field

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #8317:
URL: https://github.com/apache/inlong/pull/8317#discussion_r1243228891


##########
inlong-dashboard/src/ui/locales/cn.json:
##########
@@ -22,6 +22,7 @@
   "basic.SuccessfullyRestart": "重启成功",
   "basic.SuccessfullyStop": "停止成功",
   "meta.Sources.Name": "数据源名称",
+  "meta.Sources.NameRule": "只能包含英文字母、数字、点号(.)、中划线(-)、下划线(_)",

Review Comment:
   It seems that the source name not support dot(.) =.=!



##########
inlong-dashboard/src/ui/locales/en.json:
##########
@@ -22,6 +22,7 @@
   "basic.SuccessfullyRestart": "Successfully restart",
   "basic.SuccessfullyStop": "Successfully stop",
   "meta.Sources.Name": "Source Name",
+  "meta.Sources.NameRule": "Only English letters, numbers, dots(.), minus(-), and underscores(_)",

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #8317: [INLONG-8316][Dashboard] Update length limit for partial ID or name field

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #8317:
URL: https://github.com/apache/inlong/pull/8317#discussion_r1241700324


##########
inlong-dashboard/src/plugins/groups/common/GroupDefaultInfo.ts:
##########
@@ -39,12 +39,12 @@ export class GroupDefaultInfo implements DataWithBackend, RenderRow, RenderList
   @FieldDecorator({
     type: 'input',
     props: {
-      maxLength: 100,
+      maxLength: 200,
     },
     rules: [
       { required: true },
       {
-        pattern: /^[a-z_0-9]+$/,
+        pattern: /^[a-zA-Z0-9_.-]+$/,
         message: i18n.t('meta.Group.InlongGroupIdRules'),

Review Comment:
   Please update the description of `meta.Group.InlongGroupIdRules` at the same time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #8317: [INLONG-8316][Dashboard] Update length limit for partial ID or name field

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #8317:
URL: https://github.com/apache/inlong/pull/8317#discussion_r1243052538


##########
inlong-dashboard/src/ui/locales/cn.json:
##########
@@ -362,7 +363,7 @@
   "meta.Sinks.Kudu.FieldDescription": "描述",
   "meta.Sinks.Kudu.buckets": "Buckets",
   "meta.Group.InlongGroupId": "数据流组 ID",
-  "meta.Group.InlongGroupIdRules": "只能包含小写字母、数字、中划线、下划线",
+  "meta.Group.InlongGroupIdRules": "只能包含英文字母、数字、中划线、下划线",

Review Comment:
   **Other Chinese and English descriptions are also suggested to be modified in this way.**
   
   ```suggestion
     "meta.Group.InlongGroupIdRules": "只能包含英文字母、数字、点号(.)、中划线(-)、下划线(_)",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow merged pull request #8317: [INLONG-8316][Dashboard] Update length limit for partial ID or name field

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow merged PR #8317:
URL: https://github.com/apache/inlong/pull/8317


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #8317: [INLONG-8316][Dashboard] Update length limit for partial ID or name field

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #8317:
URL: https://github.com/apache/inlong/pull/8317#discussion_r1243051442


##########
inlong-dashboard/src/ui/locales/cn.json:
##########
@@ -22,6 +22,7 @@
   "basic.SuccessfullyRestart": "重启成功",
   "basic.SuccessfullyStop": "停止成功",
   "meta.Sources.Name": "数据源名称",
+  "meta.Sources.NameRule": "只能包含英文字母、数字、中划线、下划线",

Review Comment:
   ```suggestion
     "meta.Sources.NameRule": "只能包含英文字母、数字、中划线(-)、下划线(_)",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #8317: [INLONG-8316][Dashboard] Update length limit for partial ID or name field

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #8317:
URL: https://github.com/apache/inlong/pull/8317#discussion_r1243306918


##########
inlong-dashboard/src/plugins/sources/common/SourceDefaultInfo.ts:
##########
@@ -73,10 +74,16 @@ export class SourceDefaultInfo implements DataWithBackend, RenderRow, RenderList
 
   @FieldDecorator({
     type: 'input',
-    rules: [{ required: true }],
+    rules: [
+      { required: true },
+      {
+        pattern: /^[a-zA-Z0-9_-]*$/,

Review Comment:
   ```suggestion
           pattern: /^[a-zA-Z0-9_.-]*$/,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org