You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/07/24 19:31:11 UTC
[GitHub] [incubator-pekko-http] pjfanning opened a new pull request, #268: update note about h2spec
pjfanning opened a new pull request, #268:
URL: https://github.com/apache/incubator-pekko-http/pull/268
see https://github.com/apache/incubator-pekko-http/issues/218#issuecomment-1648476214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #268: update note about h2spec
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #268:
URL: https://github.com/apache/incubator-pekko-http/pull/268#discussion_r1273238346
##########
README.md:
##########
@@ -39,8 +39,8 @@ The documentation is available at
Some tests for HTTP/2 compliance use [h2spec](https://github.com/summerwind/h2spec). The sbt build downloads
pre-built binaries from the GitHub releases page for the h2spec project. These binaries are not available for all
-operating systems. In particular, we have received reports of issues with running the tests on Apple Mac Silicon
-machines.
+operating systems. Apple Mac Silicon users may need to install [Rosetta](https://support.apple.com/en-us/HT211861) if
Review Comment:
> sure - the language used is neutral enough - it may be best to leave it as is
Actually leave it as it is, i.e. ignore my suggestion. I misremembered regarding rosetta being installed by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning merged pull request #268: update note about h2spec
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #268:
URL: https://github.com/apache/incubator-pekko-http/pull/268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #268: update note about h2spec
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #268:
URL: https://github.com/apache/incubator-pekko-http/pull/268#discussion_r1273233988
##########
README.md:
##########
@@ -39,8 +39,8 @@ The documentation is available at
Some tests for HTTP/2 compliance use [h2spec](https://github.com/summerwind/h2spec). The sbt build downloads
pre-built binaries from the GitHub releases page for the h2spec project. These binaries are not available for all
-operating systems. In particular, we have received reports of issues with running the tests on Apple Mac Silicon
-machines.
+operating systems. Apple Mac Silicon users may need to install [Rosetta](https://support.apple.com/en-us/HT211861) if
Review Comment:
I don't remember doing this but after some preliminary google searching you are indeed correct, in that the first time you use an x86_64 app it will prompt you with a dialog to install it (which is probably why I don't remember).
In that case just ignore this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #268: update note about h2spec
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #268:
URL: https://github.com/apache/incubator-pekko-http/pull/268#discussion_r1273200272
##########
README.md:
##########
@@ -39,8 +39,8 @@ The documentation is available at
Some tests for HTTP/2 compliance use [h2spec](https://github.com/summerwind/h2spec). The sbt build downloads
pre-built binaries from the GitHub releases page for the h2spec project. These binaries are not available for all
-operating systems. In particular, we have received reports of issues with running the tests on Apple Mac Silicon
-machines.
+operating systems. Apple Mac Silicon users may need to install [Rosetta](https://support.apple.com/en-us/HT211861) if
Review Comment:
So having a Mac M1, it already comes preinstalled with Rosetta and I never had to manually install it. Not a big deal, but you can probably rephrase it to something like.
"h2spec on Apple Mac Sillicon relies on Rosetta which should be already preinstalled. If not you can install it manually from https://support.apple.com/en-us/HT211861"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #268: update note about h2spec
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #268:
URL: https://github.com/apache/incubator-pekko-http/pull/268#discussion_r1273233988
##########
README.md:
##########
@@ -39,8 +39,8 @@ The documentation is available at
Some tests for HTTP/2 compliance use [h2spec](https://github.com/summerwind/h2spec). The sbt build downloads
pre-built binaries from the GitHub releases page for the h2spec project. These binaries are not available for all
-operating systems. In particular, we have received reports of issues with running the tests on Apple Mac Silicon
-machines.
+operating systems. Apple Mac Silicon users may need to install [Rosetta](https://support.apple.com/en-us/HT211861) if
Review Comment:
I don't remember doing this but after some preliminary google searching you are indeed correct, in that the first time you use an x86_64 app it will prompt you to install it (which is probably why I don't remember).
In that case just ignore this convo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #268: update note about h2spec
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #268:
URL: https://github.com/apache/incubator-pekko-http/pull/268#discussion_r1273200272
##########
README.md:
##########
@@ -39,8 +39,8 @@ The documentation is available at
Some tests for HTTP/2 compliance use [h2spec](https://github.com/summerwind/h2spec). The sbt build downloads
pre-built binaries from the GitHub releases page for the h2spec project. These binaries are not available for all
-operating systems. In particular, we have received reports of issues with running the tests on Apple Mac Silicon
-machines.
+operating systems. Apple Mac Silicon users may need to install [Rosetta](https://support.apple.com/en-us/HT211861) if
Review Comment:
So having a Mac M1, it already comes preinstalled with Rosetta and I never had to manually install it. Not a big deal, but you can probably rephrase this to.
"h2spec on Apple Mac Sillicon relies on Rosetta which should be already preinstalled. If not you can install it manually from https://support.apple.com/en-us/HT211861"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] nvollmar commented on a diff in pull request #268: update note about h2spec
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #268:
URL: https://github.com/apache/incubator-pekko-http/pull/268#discussion_r1273213157
##########
README.md:
##########
@@ -39,8 +39,8 @@ The documentation is available at
Some tests for HTTP/2 compliance use [h2spec](https://github.com/summerwind/h2spec). The sbt build downloads
pre-built binaries from the GitHub releases page for the h2spec project. These binaries are not available for all
-operating systems. In particular, we have received reports of issues with running the tests on Apple Mac Silicon
-machines.
+operating systems. Apple Mac Silicon users may need to install [Rosetta](https://support.apple.com/en-us/HT211861) if
Review Comment:
afaik Rosetta 2 is not preinstalled on Apple Silicon Macs, but a dialog to install it will pop up the first time you try to start an x86 application
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #268: update note about h2spec
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #268:
URL: https://github.com/apache/incubator-pekko-http/pull/268#discussion_r1273236999
##########
README.md:
##########
@@ -39,8 +39,8 @@ The documentation is available at
Some tests for HTTP/2 compliance use [h2spec](https://github.com/summerwind/h2spec). The sbt build downloads
pre-built binaries from the GitHub releases page for the h2spec project. These binaries are not available for all
-operating systems. In particular, we have received reports of issues with running the tests on Apple Mac Silicon
-machines.
+operating systems. Apple Mac Silicon users may need to install [Rosetta](https://support.apple.com/en-us/HT211861) if
Review Comment:
sure - the language used is neutral enough - it may be best to leave it as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org