You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/09/20 03:38:26 UTC
Review Request 38531: CMake: Update CMake config to build Mesos
against picojson v1.3.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38531/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Update CMake config to build Mesos against picojson v1.3.0.
Diffs
-----
3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423
Diff: https://reviews.apache.org/r/38531/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Windows 10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer
Re: Review Request 38531: CMake: Update CMake config to build Mesos
against picojson v1.3.0.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38531/#review100593
-----------------------------------------------------------
LGTM.
- Artem Harutyunyan
On Sept. 19, 2015, 7:07 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38531/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2015, 7:07 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3345
> https://issues.apache.org/jira/browse/MESOS-3345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Update CMake config to build Mesos against picojson v1.3.0.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423
>
> Diff: https://reviews.apache.org/r/38531/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38531: CMake: Update CMake config to build Mesos
against picojson v1.3.0.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38531/#review99784
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Sept. 19, 2015, 7:07 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38531/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2015, 7:07 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3345
> https://issues.apache.org/jira/browse/MESOS-3345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Update CMake config to build Mesos against picojson v1.3.0.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423
>
> Diff: https://reviews.apache.org/r/38531/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38531: CMake: Update CMake config to build Mesos
against picojson v1.3.0.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38531/#review100725
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Sept. 20, 2015, 2:07 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38531/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2015, 2:07 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3345
> https://issues.apache.org/jira/browse/MESOS-3345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Update CMake config to build Mesos against picojson v1.3.0.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423
>
> Diff: https://reviews.apache.org/r/38531/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38531: CMake: Update CMake config to build Mesos
against picojson v1.3.0.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38531/#review99693
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38456, 38457, 38529, 38530, 38531]
All tests passed.
- Mesos ReviewBot
On Sept. 20, 2015, 2:07 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38531/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2015, 2:07 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3345
> https://issues.apache.org/jira/browse/MESOS-3345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Update CMake config to build Mesos against picojson v1.3.0.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423
>
> Diff: https://reviews.apache.org/r/38531/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38531: CMake: Update CMake config to build Mesos
against picojson v1.3.0.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38531/
-----------------------------------------------------------
(Updated Sept. 20, 2015, 2:07 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3345
https://issues.apache.org/jira/browse/MESOS-3345
Repository: mesos
Description
-------
CMake: Update CMake config to build Mesos against picojson v1.3.0.
Diffs
-----
3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423
Diff: https://reviews.apache.org/r/38531/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Windows 10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer