You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/06 10:34:28 UTC
[GitHub] [incubator-doris] weizuo93 opened a new pull request #4268: Tablets webpage
weizuo93 opened a new pull request #4268:
URL: https://github.com/apache/incubator-doris/pull/4268
## Proposed changes
A new feature has been added to acquire tablet id and schema hash of all the tablets on a particular BE node via Web pageļ¼so that more detailed information of each tablet can be obtained according to these tablet id and schema hash. In accordance with different web request, there are two ways (table and json)to show these acquired tablet id and schema hash on Web page.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [] I have create an issue on #ISSUE, and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [x] Any dependent changes have been merged
## Further comments
Not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4268: [Feature][Web] Add new feature to list all tablets on a particular BE
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4268:
URL: https://github.com/apache/incubator-doris/pull/4268#issuecomment-670282812
That would be a useful feature! But I have some suggestions:
1. There may be hundreds of thousands of tablet on one BE, so it better to add some query parameter like `limit` or `offset` to limit the number of tablets returned. And use a default value, like limit 1000.
2. I sorting out the RESTful API of Doris, in this PR #4261, it only describe the RESTful API response body of FE, bug I thinks BE can also follow the rule. the response body is like:
```
{
"msg": "OK",
"code": 0,
"data": {
your real result data....
},
"count": 0
}
```
3. Document. Every new API need a document in both English and Chinese. You can put them under `administrator-guide/http-actions/`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] weizuo93 commented on pull request #4268: [Feature][Web] Add new feature to list all tablets on a particular BE
Posted by GitBox <gi...@apache.org>.
weizuo93 commented on pull request #4268:
URL: https://github.com/apache/incubator-doris/pull/4268#issuecomment-670301688
> That would be a useful feature! But I have some suggestions:
>
> 1. There may be hundreds of thousands of tablet on one BE, so it better to add some query parameter like `limit` or `offset` to limit the number of tablets returned. And use a default value, like limit 1000.
> 2. I sorting out the RESTful API of Doris, in this PR #4261, it only describe the RESTful API response body of FE, bug I thinks BE can also follow the rule. the response body is like:
>
> ```
> {
> "msg": "OK",
> "code": 0,
> "data": {
> your real result data....
> },
> "count": 0
> }
> ```
>
> 1. Document. Every new API need a document in both English and Chinese. You can put them under `administrator-guide/http-actions/`
Thank you very much for your suggestions, and I think your suggestions are very useful. I will modify my work:
(1) API Response body will follow the rule in PR #4261.
(2) I will add a document in both English and Chinese to describe the new API.
However, the purpose of our work is to view all the tablets on a BE node, it is necessary to return all the tablets. In addition, only the tablet id and schema hash are returned in the data, thus the returned data capacity is not large.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4268: [Feature][Web] Add new feature to list all tablets on a particular BE
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4268:
URL: https://github.com/apache/incubator-doris/pull/4268
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org