Re: [PR] [Core] Supports generating nested complex type in RandomParquetDataGenerator [incubator-gluten]

["PHILO-HE (via GitHub)" <gi...@apache.org>]

PHILO-HE commented on PR #5200:
URL: https://github.com/apache/incubator-gluten/pull/5200#issuecomment-2029005036

   > @PHILO-HE As there are physical operators like `ColumnarShuffleExchange` `RowToVeloxColumnarExec` which are not "fallback" operators, this patch renames below test methods: rename `checkOperatorMatch` -> `checkTransformerMatch` rename `checkFallbackOperatorMatch` -> `checkOperatorMatch`
   
   @marin-ma, maybe, better to rename the original `checkOperatorMatch` to `checkGlutenOperatorMatch` (see below code, where `TransformerSupport` has been replaced by `GlutenPlan`), and the other to `checkSparkOperatorMatch`?
   
   ```
     def checkGlutenOperatorMatch[T <: GlutenPlan](df: DataFrame)(implicit tag: ClassTag[T]): Unit = {
   ```
   Then,  gluten's shuffle, C2R, R2C operator can be checked with `checkGlutenOperatorMatch`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org