You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/27 15:57:06 UTC
[GitHub] [shardingsphere] Ahoo-Wang opened a new pull request, #17160: fix the CosIdModShardingAlgorithm lost the mod configuration parameter.
Ahoo-Wang opened a new pull request, #17160:
URL: https://github.com/apache/shardingsphere/pull/17160
Fixes #17159.
Changes proposed in this pull request:
- fix the `CosIdModShardingAlgorithm` lost the mod configuration parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #17160: fix the CosIdModShardingAlgorithm lost the mod configuration parameter.
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #17160:
URL: https://github.com/apache/shardingsphere/pull/17160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #17160: fix the CosIdModShardingAlgorithm lost the mod configuration parameter.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17160:
URL: https://github.com/apache/shardingsphere/pull/17160#issuecomment-1111579563
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17160?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17160](https://codecov.io/gh/apache/shardingsphere/pull/17160?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4a5c8e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3c0dbde500ef2d15336e741fde6fa9b8a3a0d33d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c0dbde) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #17160 +/- ##
============================================
- Coverage 60.36% 60.36% -0.01%
Complexity 2114 2114
============================================
Files 3491 3493 +2
Lines 52220 52222 +2
Branches 8890 8890
============================================
+ Hits 31525 31526 +1
- Misses 18050 18051 +1
Partials 2645 2645
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rding/algorithm/sharding/cosid/PropertiesUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/17160/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvYWxnb3JpdGhtL3NoYXJkaW5nL2Nvc2lkL1Byb3BlcnRpZXNVdGlsLmphdmE=) | `66.66% <100.00%> (ø)` | |
| [...apache/shardingsphere/infra/merge/MergeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/17160/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtbWVyZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL21lcmdlL01lcmdlRW5naW5lLmphdmE=) | `90.00% <0.00%> (-0.63%)` | :arrow_down: |
| [...rsistRepositoryConfigurationYamlSwapperEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/17160/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL21vZGUvUGVyc2lzdFJlcG9zaXRvcnlDb25maWd1cmF0aW9uWWFtbFN3YXBwZXJFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...sistRepositoryConfigurationYamlSwapperFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/17160/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL21vZGUvUGVyc2lzdFJlcG9zaXRvcnlDb25maWd1cmF0aW9uWWFtbFN3YXBwZXJGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...infra/merge/engine/ResultProcessEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/17160/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtbWVyZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL21lcmdlL2VuZ2luZS9SZXN1bHRQcm9jZXNzRW5naW5lRmFjdG9yeS5qYXZh) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17160?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17160?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3c0dbde...a4a5c8e](https://codecov.io/gh/apache/shardingsphere/pull/17160?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Ahoo-Wang commented on pull request #17160: fix the CosIdModShardingAlgorithm lost the mod configuration parameter.
Posted by GitBox <gi...@apache.org>.
Ahoo-Wang commented on PR #17160:
URL: https://github.com/apache/shardingsphere/pull/17160#issuecomment-1111659924
> It is necessary to set String value to properties. Do we need to support set other type into properties?
Yes,When configured with spring-boot yaml the value is parsed as an int.
``` yaml
sharding-algorithms:
algorithm-name:
type: COSID_MOD
props:
mod: 2
logic-name-prefix: t_table_
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org