You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/13 14:51:18 UTC

[GitHub] [airflow] dimberman commented on a change in pull request #12303: K8s yaml templates not rendered by k8sexecutor

dimberman commented on a change in pull request #12303:
URL: https://github.com/apache/airflow/pull/12303#discussion_r522998759



##########
File path: tests/kubernetes/test_pod_generator.py
##########
@@ -473,6 +480,9 @@ def test_construct_pod_empty_executor_config(self, mock_uuid):
         worker_config.metadata.labels['app'] = 'myapp'
         worker_config.metadata.name = 'pod_id-' + self.static_uuid.hex
         worker_config.metadata.namespace = 'namespace'
+        worker_config.spec.containers[0].env.append(
+            k8s.V1EnvVar(name="AIRFLOW_IS_K8S_EXECUTOR_POD", value='True')
+        )

Review comment:
       @ashb This value is different as it is applied by the `construct_pod` method. I don't think it belongs in the pod_template_file as that would be confusing to anyone reading the code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org