You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saksham Srivastava <sa...@citrix.com> on 2013/03/22 11:04:25 UTC
Review Request: CLOUDSTACK-1748: IP Reservation results in reserving the
broadcast IP of the network as well
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10078/
-----------------------------------------------------------
Review request for cloudstack, Murali Reddy and Sateesh Chodapuneedi.
Description
-------
While reserving IPs, broadcast IPs of guestvmcidr is also getting reserved.
Diffs
-----
server/src/com/cloud/api/ApiResponseHelper.java 663139d
Diff: https://reviews.apache.org/r/10078/diff/
Testing
-------
CIDR : 10.1.1.0/26 (10.1.1.1-10.1.1.62, Broadcast: 10.1.1.63)
Network CIDR: 10.1.1.0/24 (10.1.1.1-10.1.1.254, Broadcast: 10.1.1.255)
Reserved Range: 10.1.1.64-10.1.1.254
Thanks,
Saksham Srivastava
RE: Review Request: CLOUDSTACK-1748: IP Reservation results in
reserving the broadcast IP of the network as well
Posted by Saksham Srivastava <sa...@citrix.com>.
Sateesh,
I have implemented the same calculator that is used here : http://jodies.de/ipcalc?host=10.1.1.0&mask1=26&mask2=
The BroadCast IP is 10.1.1.63. Since we are not creating subnets at all for guest vms, this broadcast IP is actually to be used for reservation.
There is common broadcast IP (10.1.1.255) for the entire network.
Am I missing something?
Regards,
Saksham
________________________________
From: Sateesh Chodapuneedi
Sent: Thursday, May 02, 2013 3:55 PM
To: Saksham Srivastava; Murali Reddy
Cc: cloudstack
Subject: RE: Review Request: CLOUDSTACK-1748: IP Reservation results in reserving the broadcast IP of the network as well
Saksham,
> Since broadcast is an assignable IP so it should be a part of Reserved range. Closing the request.
Currently last IP of guest ip range is being included in reserved range.
This needs to be fixed.
User is providing CIDR to specify ip range, then we should ensure all IPs that come under that CIDR needs to be considered for guests.
Hence CIDR 10.1.1.0/26 means reservation would be 10.1.1.64 to 10.1.1.254 instead of 10.1.1.63-10.1.1.254 as per current behaviour.
Please fix this and resubmit the patch.
Regards,
Sateesh
From: Saksham Srivastava [mailto:noreply@reviews.apache.org] On Behalf Of Saksham Srivastava
Sent: 30 April 2013 14:10
To: Sateesh Chodapuneedi; Murali Reddy
Cc: Saksham Srivastava; cloudstack
Subject: Re: Review Request: CLOUDSTACK-1748: IP Reservation results in reserving the broadcast IP of the network as well
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10078/
Since we are not creating subnets for guest CIDR, there is no need for a separate broadcast IP.
The guest Broadcast will be same as the Network Broadcast.
Currently this is the behaviour :
CIDR 10.1.1.0/26
Network CIDR 10.1.1.0/24
Reserved Range : 10.1.1.63-10.1.1.254
CIDR 10.1.1.224/27
Network CIDR 10.1.1.0/24
Reserved Range : 10.1.1.1-10.1.1.224
CIDR 10.1.1.32/27
Network CIDR 10.1.1.0/24
Reserved Range : 10.1.1.1-10.1.1.32 , 10.1.1.63-10.1.1.254
Since broadcast is an assignable IP so it should be a part of Reserved range. Closing the request.
- Saksham
On March 22nd, 2013, 10:04 a.m., Saksham Srivastava wrote:
Review request for cloudstack, Murali Reddy and Sateesh Chodapuneedi.
By Saksham Srivastava.
Updated March 22, 2013, 10:04 a.m.
Description
While reserving IPs, broadcast IPs of guestvmcidr is also getting reserved.
Testing
CIDR : 10.1.1.0/26 (10.1.1.1-10.1.1.62, Broadcast: 10.1.1.63)
Network CIDR: 10.1.1.0/24 (10.1.1.1-10.1.1.254, Broadcast: 10.1.1.255)
Reserved Range: 10.1.1.64-10.1.1.254
Diffs
* server/src/com/cloud/api/ApiResponseHelper.java (663139d)
View Diff<https://reviews.apache.org/r/10078/diff/>
RE: Review Request: CLOUDSTACK-1748: IP Reservation results in
reserving the broadcast IP of the network as well
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
Saksham,
> Since broadcast is an assignable IP so it should be a part of Reserved range. Closing the request.
Currently last IP of guest ip range is being included in reserved range.
This needs to be fixed.
User is providing CIDR to specify ip range, then we should ensure all IPs that come under that CIDR needs to be considered for guests.
Hence CIDR 10.1.1.0/26 means reservation would be 10.1.1.64 to 10.1.1.254 instead of 10.1.1.63-10.1.1.254 as per current behaviour.
Please fix this and resubmit the patch.
Regards,
Sateesh
From: Saksham Srivastava [mailto:noreply@reviews.apache.org] On Behalf Of Saksham Srivastava
Sent: 30 April 2013 14:10
To: Sateesh Chodapuneedi; Murali Reddy
Cc: Saksham Srivastava; cloudstack
Subject: Re: Review Request: CLOUDSTACK-1748: IP Reservation results in reserving the broadcast IP of the network as well
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10078/
Since we are not creating subnets for guest CIDR, there is no need for a separate broadcast IP.
The guest Broadcast will be same as the Network Broadcast.
Currently this is the behaviour :
CIDR 10.1.1.0/26
Network CIDR 10.1.1.0/24
Reserved Range : 10.1.1.63-10.1.1.254
CIDR 10.1.1.224/27
Network CIDR 10.1.1.0/24
Reserved Range : 10.1.1.1-10.1.1.224
CIDR 10.1.1.32/27
Network CIDR 10.1.1.0/24
Reserved Range : 10.1.1.1-10.1.1.32 , 10.1.1.63-10.1.1.254
Since broadcast is an assignable IP so it should be a part of Reserved range. Closing the request.
- Saksham
On March 22nd, 2013, 10:04 a.m., Saksham Srivastava wrote:
Review request for cloudstack, Murali Reddy and Sateesh Chodapuneedi.
By Saksham Srivastava.
Updated March 22, 2013, 10:04 a.m.
Description
While reserving IPs, broadcast IPs of guestvmcidr is also getting reserved.
Testing
CIDR : 10.1.1.0/26 (10.1.1.1-10.1.1.62, Broadcast: 10.1.1.63)
Network CIDR: 10.1.1.0/24 (10.1.1.1-10.1.1.254, Broadcast: 10.1.1.255)
Reserved Range: 10.1.1.64-10.1.1.254
Diffs
* server/src/com/cloud/api/ApiResponseHelper.java (663139d)
View Diff<https://reviews.apache.org/r/10078/diff/>
Re: Review Request: CLOUDSTACK-1748: IP Reservation results in reserving the
broadcast IP of the network as well
Posted by Saksham Srivastava <sa...@citrix.com>.
> On April 18, 2013, 5:18 p.m., Sateesh Chodapuneedi wrote:
> >
Since we are not creating subnets for guest CIDR, there is no need for a separate broadcast IP.
The guest Broadcast will be same as the Network Broadcast.
Currently this is the behaviour :
CIDR 10.1.1.0/26
Network CIDR 10.1.1.0/24
Reserved Range : 10.1.1.63-10.1.1.254
CIDR 10.1.1.224/27
Network CIDR 10.1.1.0/24
Reserved Range : 10.1.1.1-10.1.1.224
CIDR 10.1.1.32/27
Network CIDR 10.1.1.0/24
Reserved Range : 10.1.1.1-10.1.1.32 , 10.1.1.63-10.1.1.254
Since broadcast is an assignable IP so it should be a part of Reserved range. Closing the request.
- Saksham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10078/#review19395
-----------------------------------------------------------
On March 22, 2013, 10:04 a.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10078/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 10:04 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> While reserving IPs, broadcast IPs of guestvmcidr is also getting reserved.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/ApiResponseHelper.java 663139d
>
> Diff: https://reviews.apache.org/r/10078/diff/
>
>
> Testing
> -------
>
> CIDR : 10.1.1.0/26 (10.1.1.1-10.1.1.62, Broadcast: 10.1.1.63)
> Network CIDR: 10.1.1.0/24 (10.1.1.1-10.1.1.254, Broadcast: 10.1.1.255)
> Reserved Range: 10.1.1.64-10.1.1.254
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request: CLOUDSTACK-1748: IP Reservation results in reserving the
broadcast IP of the network as well
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10078/#review19395
-----------------------------------------------------------
server/src/com/cloud/api/ApiResponseHelper.java
<https://reviews.apache.org/r/10078/#comment40104>
The ip before startVmIp doesn't have to be omitted from reserved ip range. Just leave existing statement as it is. This line need not be modified.
server/src/com/cloud/api/ApiResponseHelper.java
<https://reviews.apache.org/r/10078/#comment40105>
Do not skip the IP before startVmIp. Leave the existing expresssion (estartVmIp-1) as it is. Only the expression (endVmIp + 1) need be modified.
- Sateesh Chodapuneedi
On March 22, 2013, 10:04 a.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10078/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 10:04 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> While reserving IPs, broadcast IPs of guestvmcidr is also getting reserved.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/ApiResponseHelper.java 663139d
>
> Diff: https://reviews.apache.org/r/10078/diff/
>
>
> Testing
> -------
>
> CIDR : 10.1.1.0/26 (10.1.1.1-10.1.1.62, Broadcast: 10.1.1.63)
> Network CIDR: 10.1.1.0/24 (10.1.1.1-10.1.1.254, Broadcast: 10.1.1.255)
> Reserved Range: 10.1.1.64-10.1.1.254
>
>
> Thanks,
>
> Saksham Srivastava
>
>