You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Doug Cutting (Commented) (JIRA)" <ji...@apache.org> on 2012/01/16 22:45:38 UTC
[jira] [Commented] (AVRO-994) TestFileSpanStorage.testTonsOfSpans()
fails on my slow VM
[ https://issues.apache.org/jira/browse/AVRO-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187219#comment-13187219 ]
Doug Cutting commented on AVRO-994:
-----------------------------------
+1 That's a better way to fix such things, rather than just increasing the sleep time as we have before. Thanks!
> TestFileSpanStorage.testTonsOfSpans() fails on my slow VM
> ---------------------------------------------------------
>
> Key: AVRO-994
> URL: https://issues.apache.org/jira/browse/AVRO-994
> Project: Avro
> Issue Type: Bug
> Reporter: James Baldassari
> Priority: Minor
> Attachments: AVRO-994.patch
>
>
> {noformat}
> Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 15.554 sec <<< FAILURE!
> testTonsOfSpans(org.apache.avro.ipc.trace.TestFileSpanStorage) Time elapsed: 3.853 sec <<< FAILURE!
> java.lang.AssertionError: expected:<50000> but was:<42356>
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.failNotEquals(Assert.java:647)
> at org.junit.Assert.assertEquals(Assert.java:128)
> at org.junit.Assert.assertEquals(Assert.java:472)
> at org.junit.Assert.assertEquals(Assert.java:456)
> at org.apache.avro.ipc.trace.TestFileSpanStorage.testTonsOfSpans(TestFileSpanStorage.java:70)
> {noformat}
> The issue seems to be the {{Thread.sleep(2000)}} on line 66. Doubling this to 4000ms causes the test to pass. In general it might be better to make this sleep event-based rather than using a fixed sleep time. If that isn't possible, then maybe using some sort of a retry loop would work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira