You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Ankit Kailaswar <an...@gmail.com> on 2017/10/17 12:07:52 UTC
Re: Review Request 61881: Lens-1461:Lens services state are not
persisted correctly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 12:07 p.m.)
Review request for lens and Puneet Gupta.
Bugs: LENS-1461
https://issues.apache.org/jira/browse/LENS-1461
Repository: lens
Description
-------
Persist process for Session service should not fail if any session in invalid. Persist service should ignore these session and continue persisting state of other session instead of failing.
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java b480d140
Diff: https://reviews.apache.org/r/61881/diff/2/
Changes: https://reviews.apache.org/r/61881/diff/1-2/
Testing
-------
Thanks,
Ankit Kailaswar
Re: Review Request 61881: Lens-1461:Lens services state are not
persisted correctly
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review189401
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On Oct. 26, 2017, 3:28 p.m., Ankit Kailaswar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 3:28 p.m.)
>
>
> Review request for lens and Puneet Gupta.
>
>
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
>
>
> Repository: lens
>
>
> Description
> -------
>
> Persist process for Session service should not fail if any session in invalid. Persist service should ignore these session and continue persisting state of other session instead of failing.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java b480d140
>
>
> Diff: https://reviews.apache.org/r/61881/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ankit Kailaswar
>
>
Re: Review Request 61881: Lens-1461:Lens services state are not
persisted correctly
Posted by Ankit Kailaswar <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/
-----------------------------------------------------------
(Updated Oct. 26, 2017, 3:28 p.m.)
Review request for lens and Puneet Gupta.
Bugs: LENS-1461
https://issues.apache.org/jira/browse/LENS-1461
Repository: lens
Description
-------
Persist process for Session service should not fail if any session in invalid. Persist service should ignore these session and continue persisting state of other session instead of failing.
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java b480d140
Diff: https://reviews.apache.org/r/61881/diff/4/
Changes: https://reviews.apache.org/r/61881/diff/3-4/
Testing
-------
Thanks,
Ankit Kailaswar
Re: Review Request 61881: Lens-1461:Lens services state are not
persisted correctly
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review189292
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 424 (patched)
<https://reviews.apache.org/r/61881/#comment266306>
This is not required. sessions List size should be enough .
- Puneet Gupta
On Oct. 26, 2017, 8:23 a.m., Ankit Kailaswar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 8:23 a.m.)
>
>
> Review request for lens and Puneet Gupta.
>
>
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
>
>
> Repository: lens
>
>
> Description
> -------
>
> Persist process for Session service should not fail if any session in invalid. Persist service should ignore these session and continue persisting state of other session instead of failing.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java b480d140
>
>
> Diff: https://reviews.apache.org/r/61881/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ankit Kailaswar
>
>
Re: Review Request 61881: Lens-1461:Lens services state are not
persisted correctly
Posted by Ankit Kailaswar <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/
-----------------------------------------------------------
(Updated Oct. 26, 2017, 8:23 a.m.)
Review request for lens and Puneet Gupta.
Bugs: LENS-1461
https://issues.apache.org/jira/browse/LENS-1461
Repository: lens
Description
-------
Persist process for Session service should not fail if any session in invalid. Persist service should ignore these session and continue persisting state of other session instead of failing.
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java b480d140
Diff: https://reviews.apache.org/r/61881/diff/3/
Changes: https://reviews.apache.org/r/61881/diff/2-3/
Testing
-------
Thanks,
Ankit Kailaswar
Re: Review Request 61881: Lens-1461:Lens services state are not
persisted correctly
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review189274
-----------------------------------------------------------
Dont see the latest patch uploaded on review board .
- Puneet Gupta
On Oct. 17, 2017, 12:07 p.m., Ankit Kailaswar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 12:07 p.m.)
>
>
> Review request for lens and Puneet Gupta.
>
>
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
>
>
> Repository: lens
>
>
> Description
> -------
>
> Persist process for Session service should not fail if any session in invalid. Persist service should ignore these session and continue persisting state of other session instead of failing.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java b480d140
>
>
> Diff: https://reviews.apache.org/r/61881/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ankit Kailaswar
>
>
Re: Review Request 61881: Lens-1461:Lens services state are not
persisted correctly
Posted by Ankit Kailaswar <an...@gmail.com>.
> On Oct. 25, 2017, 5:32 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
> > Lines 432 (patched)
> > <https://reviews.apache.org/r/61881/diff/2/?file=1860577#file1860577line432>
> >
> > Won't this cause issues While reading sessions back? As the count of sessions persisted is written as `SESSION_MAP.size()`. It'll try to read that many session objects. What will happen if some of the sessions are not written at all?
fixed it, now storing all sessions in memory before persisting individually.
- Ankit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review189159
-----------------------------------------------------------
On Oct. 17, 2017, 12:07 p.m., Ankit Kailaswar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 12:07 p.m.)
>
>
> Review request for lens and Puneet Gupta.
>
>
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
>
>
> Repository: lens
>
>
> Description
> -------
>
> Persist process for Session service should not fail if any session in invalid. Persist service should ignore these session and continue persisting state of other session instead of failing.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java b480d140
>
>
> Diff: https://reviews.apache.org/r/61881/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ankit Kailaswar
>
>
Re: Review Request 61881: Lens-1461:Lens services state are not
persisted correctly
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review189159
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 432 (patched)
<https://reviews.apache.org/r/61881/#comment266089>
Won't this cause issues While reading sessions back? As the count of sessions persisted is written as `SESSION_MAP.size()`. It'll try to read that many session objects. What will happen if some of the sessions are not written at all?
- Rajat Khandelwal
On Oct. 17, 2017, 5:37 p.m., Ankit Kailaswar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 5:37 p.m.)
>
>
> Review request for lens and Puneet Gupta.
>
>
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
>
>
> Repository: lens
>
>
> Description
> -------
>
> Persist process for Session service should not fail if any session in invalid. Persist service should ignore these session and continue persisting state of other session instead of failing.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java b480d140
>
>
> Diff: https://reviews.apache.org/r/61881/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ankit Kailaswar
>
>