You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/01 06:34:32 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1164: Fix the build break during porting the latest libc++

xiaoxiang781216 opened a new pull request #1164:
URL: https://github.com/apache/incubator-nuttx/pull/1164


   ## Summary
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1164: Fix the build break during porting the latest libc++

Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1164:
URL: https://github.com/apache/incubator-nuttx/pull/1164#discussion_r433080790



##########
File path: include/stdlib.h
##########
@@ -216,6 +256,21 @@ FAR void *memalign(size_t, size_t);
 FAR void *zalloc(size_t);
 FAR void *calloc(size_t, size_t);
 
+#ifdef __cplusplus
+inline FAR void *aligned_alloc(size_t a, size_t s)
+{
+  return memalign(a, s);

Review comment:
       Ah I see that now.  Looks like it should be, but is not implemented.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1164: Fix the build break during porting the latest libc++

Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1164:
URL: https://github.com/apache/incubator-nuttx/pull/1164#discussion_r433074048



##########
File path: include/stdlib.h
##########
@@ -216,6 +256,21 @@ FAR void *memalign(size_t, size_t);
 FAR void *zalloc(size_t);
 FAR void *calloc(size_t, size_t);
 
+#ifdef __cplusplus
+inline FAR void *aligned_alloc(size_t a, size_t s)
+{
+  return memalign(a, s);

Review comment:
       Is it OK for errno to get set by calling this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo merged pull request #1164: Fix the build break during porting the latest libc++

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #1164:
URL: https://github.com/apache/incubator-nuttx/pull/1164


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1164: Fix the build break during porting the latest libc++

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1164:
URL: https://github.com/apache/incubator-nuttx/pull/1164#discussion_r433078488



##########
File path: include/stdlib.h
##########
@@ -216,6 +256,21 @@ FAR void *memalign(size_t, size_t);
 FAR void *zalloc(size_t);
 FAR void *calloc(size_t, size_t);
 
+#ifdef __cplusplus
+inline FAR void *aligned_alloc(size_t a, size_t s)
+{
+  return memalign(a, s);

Review comment:
       memalign don't set errno too, so errno isn't an issue here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org