Review Request 14809: HIVE-5268: HiveServer2 accumulates orphaned OperationHandle objects when a client fails while executing query

[Thiruvel Thirumoolan <th...@yahoo-inc.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14809/
-----------------------------------------------------------

Review request for hive and Vaibhav Gumashta.


Bugs: HIVE-5268
    https://issues.apache.org/jira/browse/HIVE-5268


Repository: hive-git


Description
-------

This is a prototype of the patch we have to cleanup resources on HS2 on client disconnects. This has worked for Hive-10.

An updated patch to handle async query execution and session timeouts is on the way.


Diffs
-----

  common/src/java/org/apache/hadoop/hive/common/thrift/HiveThriftChainedEventHandler.java PRE-CREATION 
  jdbc/src/test/org/apache/hive/service/cli/thrift/TestDisconnectCleanupEventHandler.java PRE-CREATION 
  service/src/java/org/apache/hive/service/cli/CLIService.java 1a7f338 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62 
  service/src/java/org/apache/hive/service/cli/thrift/DisconnectCleanupEventHandler.java PRE-CREATION 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java 9c8f5c1 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 857e627 

Diff: https://reviews.apache.org/r/14809/diff/


Testing
-------

A new test case to test preliminaries.
Manual testing: Start HS2 on a machine and launch a job through JDBC. Before the job is done, kill the client. The server will cleanup all resources, scratch directory etc at the end of the query. 


Thanks,

Thiruvel Thirumoolan