[GitHub] [trafficcontrol-trafficops-types] ocket8888 commented on a diff in pull request #2: Add `ttlOverride` to `RequestCDN`

["ocket8888 (via GitHub)" <gi...@apache.org>]

ocket8888 commented on code in PR #2:
URL: https://github.com/apache/trafficcontrol-trafficops-types/pull/2#discussion_r1108701418


##########
src/cdn.ts:
##########
@@ -26,17 +26,19 @@ export interface RequestCDN {
 	domainName:    string;
 	/** The name of the CDN. */
 	name:          string;
+	/**
+	 * A TTL (Time To Live) value, in seconds, that, if set, overrides all set
+	 * TTL values on Delivery Services in this CDN.
+	 */
+	ttlOverride?: number | null;

Review Comment:
   I don't believe this is allowed to be `null` in responses; I think the `omitempty` guarantees that any "null" values are coerced to `undefined`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org