You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/20 14:39:24 UTC

[GitHub] [incubator-nuttx] klmchp opened a new pull request #336: remove nested irq_save/restore code

klmchp opened a new pull request #336: remove nested irq_save/restore code
URL: https://github.com/apache/incubator-nuttx/pull/336
 
 
   Hi ,
   Fix nested irq save/restore operation in sam_eefc.c.
   
   BR
   Kevin Liu

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] klmchp commented on issue #336: remove nested irq_save/restore code

Posted by GitBox <gi...@apache.org>.
klmchp commented on issue #336: remove nested irq_save/restore code
URL: https://github.com/apache/incubator-nuttx/pull/336#issuecomment-589163976
 
 
   Thanks to Greg's work, modification merged to master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] klmchp opened a new pull request #336: remove nested irq_save/restore code

Posted by GitBox <gi...@apache.org>.
klmchp opened a new pull request #336: remove nested irq_save/restore code
URL: https://github.com/apache/incubator-nuttx/pull/336
 
 
   Hi ,
   Fix nested irq save/restore operation in sam_eefc.c.
   
   BR
   Kevin Liu

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #336: remove nested irq_save/restore code

Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #336: remove nested irq_save/restore code
URL: https://github.com/apache/incubator-nuttx/pull/336#issuecomment-589087924
 
 
   I would let me re-open it because I removed branch pr336

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #336: remove nested irq_save/restore code

Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #336: remove nested irq_save/restore code
URL: https://github.com/apache/incubator-nuttx/pull/336#issuecomment-589086070
 
 
   No, it won't let me do that.  You will have to fix the PR.  I see conflict:
   
       Conflicting files
       arch/arm/src/samv7/sam_eefc.c
       arch/arm/src/samv7/sam_eefc.h
       arch/arm/src/samv7/sam_uid.c
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #336: remove nested irq_save/restore code

Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #336: remove nested irq_save/restore code
URL: https://github.com/apache/incubator-nuttx/pull/336#issuecomment-589087145
 
 
   Ooops hit the wrong button again.  I did not mean to close this.  Bad habit.
   Hmm.. now it won't let me re-open it???

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] klmchp closed pull request #336: remove nested irq_save/restore code

Posted by GitBox <gi...@apache.org>.
klmchp closed pull request #336: remove nested irq_save/restore code
URL: https://github.com/apache/incubator-nuttx/pull/336
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #336: remove nested irq_save/restore code

Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #336: remove nested irq_save/restore code
URL: https://github.com/apache/incubator-nuttx/pull/336#issuecomment-589085249
 
 
   This is a problem with this PR.  In includes the same commit as PR328 related EEFC and UUID.  I will merge to a branch and pick out the single commit that you intended.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo closed pull request #336: remove nested irq_save/restore code

Posted by GitBox <gi...@apache.org>.
patacongo closed pull request #336: remove nested irq_save/restore code
URL: https://github.com/apache/incubator-nuttx/pull/336
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services