You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/08/11 13:53:51 UTC

[GitHub] [buildstream] gtristan commented on a diff in pull request #1707: Cache full build tree for debugging failed builds

gtristan commented on code in PR #1707:
URL: https://github.com/apache/buildstream/pull/1707#discussion_r943513810


##########
src/buildstream/_artifact.py:
##########
@@ -52,7 +52,7 @@
 #
 class Artifact:
 
-    version = 1
+    version = 2

Review Comment:
   The line:
   
   ```
     int32 version = 1;
   ```
   
   Indicates that the *field number* in the artifact proto is 1, this number 1 will never change.
   
   The indicates that it need not be incremented for an optional field, however given that buildstream requires this field *instead* of the buildtree for some operations, it's probably more prudent to just bump the field.
   
   In any case, since we bump the `BST_ARTIFACT_VERSION` we will anyway be loading different artifacts.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org